Date: Sun, 20 Apr 2014 12:22:12 +0200 From: Antoine Brodin <antoine@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: Commit logs for 2014/04/11 Message-ID: <CAALwa8=zYC8Gf9O7vmq6L-NoKJEvmWVPb9m3O7SwbHvNS1LPtA@mail.gmail.com> In-Reply-To: <20140420101807.GA7694@FreeBSD.org> References: <20140412035900.3C695121E45@apnoea.adamw.org> <EA3162FC-904F-4209-81D8-67CDADA357A2@adamw.org> <20140420092922.GA90642@FreeBSD.org> <B8427660C28547FE27FAF9F7@atuin.in.mat.cc> <20140420101807.GA7694@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 20, 2014 at 12:18 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Sun, Apr 20, 2014 at 11:46:06AM +0200, Mathieu Arnold wrote: >> +--On 20 avril 2014 09:29:22 +0000 Alexey Dokuchaev <danfe@FreeBSD.org> >> wrote: >> | On Sat, Apr 12, 2014 at 10:11:44AM -0400, Adam Weinberger wrote: >> |> * Please, please don't mandate .sample. Plenty of of ports install >> | >> | Actually, it's not really ".sample". It's any six-letter word if I read >> | the code correctly. >> >> No, it is .sample, lines 20 and 26 of the keyword definition. > > I mean it is not hardcoded inside /usr/ports/Keywords/pkg_install.awk. > I'm not familiar with /usr/ports/Keywords/sample.yaml to quickly come up > with a patch, but suspect it would also be simple to make it generic. It's definitely better to be consistent and use .sample everywhere. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8=zYC8Gf9O7vmq6L-NoKJEvmWVPb9m3O7SwbHvNS1LPtA>