Date: Wed, 11 Jan 2017 11:43:58 -0500 From: Ed Maste <emaste@freebsd.org> To: Jia-Shiun Li <jiashiun@gmail.com> Cc: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>, "freebsd-toolchain@freebsd.org" <freebsd-toolchain@freebsd.org> Subject: Re: clang on armv6 incorrectly emits call to sincos() Message-ID: <CAPyFy2Cx9isjqwJReY5Az_heSW3Oi_ZWKpyMXNyoh-UWq-0ATw@mail.gmail.com> In-Reply-To: <CAHNYxxNDskx3b8uEV%2BTxD8YUwDMQuw8YQtCYQNs0RNDbRx=1zg@mail.gmail.com> References: <CAHNYxxNDskx3b8uEV%2BTxD8YUwDMQuw8YQtCYQNs0RNDbRx=1zg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11 January 2017 at 09:42, Jia-Shiun Li <jiashiun@gmail.com> wrote: > > Think this optimization should be turned off for armv6 from base > clang/llvm, instead of patching individual ports or ports infrastructure. You're right that this needs to be fixed in the compiler or the base system, not individual ports. LLVM has a hasSinCos() and should not be emitting the sincos libcall on platforms that do not have it. Would you care to submit a PR for this? -Ed
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2Cx9isjqwJReY5Az_heSW3Oi_ZWKpyMXNyoh-UWq-0ATw>