Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 09 Dec 2002 20:48:55 +0000
From:      Ian Dowse <iedowse@maths.tcd.ie>
To:        Josef Karthauser <joe@FreeBSD.org>
Cc:        Nate Lawson <nate@root.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/usb ohci.c 
Message-ID:   <200212092048.aa11342@salmon.maths.tcd.ie>
In-Reply-To: Your message of "Mon, 09 Dec 2002 20:21:03 GMT." <20021209202103.GA658@genius.tao.org.uk> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20021209202103.GA658@genius.tao.org.uk>, Josef Karthauser writes:
>On Mon, Dec 09, 2002 at 11:58:09AM -0800, Nate Lawson wrote:
>> On Sun, 8 Dec 2002, Josef Karthauser wrote:
>> >   MFNetBSD: (partial 1.133)
>> >   - In ohci_close_pipe, wait 1ms after removing an ED to avoid possible
>> >   race
>> >     condition.
>> >   Approved by:    re (rwatson)
>>
>> Wouldn't it be better to use a mtx or tsleep/wakeup?  A delay leaves the
>> race, only making it non-deterministic.

>Probably, got a patch :)?

I haven't looked at the code, but I suspect it is to avoid a race
with the USB hardware, since each usb frame lasts for 1ms.

Ian

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <200212092048.aa11342>