Date: Thu, 24 Jan 2013 14:27:42 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Michael Gmelin <freebsd@grem.de> Cc: freebsd-ports@freebsd.org Subject: Re: Using bidirectional authentication in pkgng Message-ID: <86r4lau2wh.fsf@ds4.des.no> In-Reply-To: <20130124121942.07436be3@bsd64.grem.de> (Michael Gmelin's message of "Thu, 24 Jan 2013 12:19:42 %2B0100") References: <20130118035721.283135fb@bsd64.grem.de> <50F9B6CC.3040303@infracaninophile.co.uk> <20130122193035.4c51be04@bsd64.grem.de> <20130123004147.GG27275@ithaqua.etoilebsd.net> <86d2wuvrjg.fsf@ds4.des.no> <20130124121942.07436be3@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael Gmelin <freebsd@grem.de> writes: > Would be great if you could point out the exact issues, so I could avoid > them next time (I spent literally hours trying to clean up the code so > it complies to style(9), even though it doesn't seem like fetch really > follows it either). Other people's coding standards are always arbitrary > and, um, wrong anyway, you know ;) libfetch follows style(9) very closely, except in some parts of http.c which are too deeply nested. Just a quick summary of issues with your patch: - There are many instances of misplaced opening / closing braces. - Several lines are too long, and almost all your continuation lines are misindented. - There are many instances of missing whitespace around operators in expressions. - You declare variables inside blocks, and declarations in general are not properly sorted. There are issues with the man page as well - you didn't bump the date, sentences don't begin on new lines, and some lines are too long - but you get a million bonus points for updating it at all. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86r4lau2wh.fsf>