Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Oct 2020 08:12:43 -0500
From:      Mike Karels <mike@karels.net>
To:        Gordon Bergling <gbe@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   Re: svn commit: r366608 - in stable/12: bin/ls sbin/dhclient
Message-ID:  <202010101312.09ADChZi001500@mail.karels.net>
In-Reply-To: Your message of Sat, 10 Oct 2020 09:52:41 -0000. <202010100952.09A9qfvc048712@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: gbe (doc committer)
> Date: Sat Oct 10 09:52:41 2020
> New Revision: 366608
> URL: https://svnweb.freebsd.org/changeset/base/366608

> Log:
>   MFC r366407, r366403
>   =

>   ls(1): Bugfix for an issue reported by mandoc
>   dhclient(8): Bugfixes for some issues reported by mandoc
>   =

>   - no blank before trailing delimiter
>   - new sentence, new line

> Modified:
>   stable/12/bin/ls/ls.1
>   stable/12/sbin/dhclient/dhclient.leases.5
>   stable/12/sbin/dhclient/dhcp-options.5
> Directory Properties:
>   stable/12/   (props changed)

> Modified: stable/12/bin/ls/ls.1
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- stable/12/bin/ls/ls.1	Sat Oct 10 09:50:09 2020	(r366607)
> +++ stable/12/bin/ls/ls.1	Sat Oct 10 09:52:41 2020	(r366608)
> @@ -40,7 +40,7 @@
>  .Nd list directory contents
>  .Sh SYNOPSIS
>  .Nm
> -.Op Fl ABCFGHILPRSTUWZabcdfghiklmnopqrstuwxy1,
> +.Op Fl ABCFGHILPRSTUWZabcdfghiklmnopqrstuwxy1 ,
>  .Op Fl -color Ns =3D Ns Ar when
>  .Op Fl D Ar format
>  .Op Ar

This change is wrong, and should not have been MFC'd.  It should be fixed
correctly instead.  The comma is not a delimiter, it is an option; it shou=
ld
appear inside the brackets, not after.  The warning can be fixed by adding
\& after the comma rather than inserting a space.

		Mike



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202010101312.09ADChZi001500>