Date: Wed, 20 Mar 1996 13:59:19 -0800 (PST) From: "JULIAN Elischer" <julian@ref.tfs.com> To: scrappy@ki.net (Marc G. Fournier) Cc: current@freebsd.org Subject: Re: PATCH: small, syntax changes for devfs Message-ID: <199603202159.NAA17420@ref.tfs.com> In-Reply-To: <Pine.BSF.3.91.960320162140.3864F-100000@ki.net> from "Marc G. Fournier" at Mar 20, 96 04:29:10 pm
next in thread | previous in thread | raw e-mail | index | archive | help
>
>
> Hi again...
>
[...]
> Question...is it safe to put "printf" statements inside of the
> kernel in arbitrary places? I'm trying to figure out why set_ds_labeldevs()
> isn't creating slice devices in /devfs, and figure that putting in a few
> extra printf's might help figure it out, but just wondering if this would
> break anything. :)
you can put printf's almost anywhere.
set_ds_labeldevs doesn't make nodes?
I seem to have all the nodes on my systems...
>
>
>
> if (slice >= BASE_SLICE && sp->ds_bdev == NULL && sp->ds_size != 0) {
> mynor = minor(dkmodpart(dev, RAW_PART));
> ! sp->ds_bdev =
> ! devfs_add_devswf(bdevsw, mynor, DV_BLK, 0, 0, 0640,
> ! dsname(dname, unit, slice, RAW_PART,
> ! partname));
better to use %s than just the string..
(what if we want a device with a % in it ? :)
> ! sp->ds_cdev =
> ! devfs_add_devswf(cdevsw, mynor, DV_CHR, 0, 0, 0640,
> ! "r%s", dsname(dname, unit, slice,
> ! RAW_PART, partname));
> }
> #endif
> if (sp->ds_label == NULL) {
looks great..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199603202159.NAA17420>