Date: Sun, 1 Feb 2009 23:28:52 +0000 (UTC) From: Sean Bruno <sbruno@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/firewire firewire.c fwohci.c fwohci_pci.c fwohcivar.h sbp.c Message-ID: <200902012328.n11NSwZP068433@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
sbruno 2009-02-01 23:28:52 UTC
FreeBSD src repository
Modified files:
sys/dev/firewire firewire.c fwohci.c fwohci_pci.c
fwohcivar.h sbp.c
Log:
SVN rev 187993 on 2009-02-01 23:28:52Z by sbruno
Some updates and bug squashing in the firewire stack.
Move the interupt handler to a driver_intr_t type function as it was trying
to do way to much for a lightweight filter interrupt function.
Introduce much more locking around fc->mtx. Tested this for lock reversals
and other such lockups. Locking seems to be working better, but there
is much more to do with regard to locking. The most significant lock is
in the BUS RESET handler. It was possible, before this checkin, to set
a bus reset via "fwcontrol -r" and have the BUS RESET handler fire before
the code responsible for asserting BUS RESET was complete. This locking
fixes that issue.
Move some of the memory allocations in the fc struct to the attach function
in firewire.c
Rework the businfo.generation indicator to be merely a on/off bit now.
It's purpose according to spec is to notify the bus that the config ROM
has changed. That's it.
Catch and squash a possible panic in SBP where in the SBP_LOCK was held
during a possible error case. The error handling code would definitely
panic as it would try to acquire the SBP_LOCK on entrance.
Catch and squash a camcontrol/device lockup when firewire drives go away.
When a firewire device was powered off or disconnected from the firewire
bus, a "camcontrol rescan all" would hang trying to poll removed devices
as they were not properly detached. Don't do that.
Approved by: scottl
MFC after: 2 weeks
Revision Changes Path
1.105 +49 -36 src/sys/dev/firewire/firewire.c
1.96 +22 -18 src/sys/dev/firewire/fwohci.c
1.61 +4 -7 src/sys/dev/firewire/fwohci_pci.c
1.17 +1 -7 src/sys/dev/firewire/fwohcivar.h
1.98 +12 -1 src/sys/dev/firewire/sbp.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902012328.n11NSwZP068433>