Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Feb 1997 03:52:35 -0800 (PST)
From:      "Jordan K. Hubbard" <jkh@time.cdrom.com>
To:        dyson@freebsd.org
Cc:        bde@freebsd.org, current@freebsd.org
Subject:   dump/traverse.c:118 build failure in -current
Message-ID:  <199702161152.DAA14051@time.cdrom.com>

next in thread | raw e-mail | index | archive | help
/* Auxiliary macro to pick up files changed since previous dump. */
#ifdef FS_44INODEFMT
#define CHANGEDSINCE(dp, t) \
        ((dp)->di_mtime.tv_sec >= (t) || (dp)->di_ctime.tv_sec >= (t))
#else
#define CHANGEDSINCE(dp, t) \
        ((dp)->di_mtime >= (t) || (dp)->di_ctime >= (t))
#endif

FS_44INODEFMT is defined as 2 /usr/include/ufs/ffs/fs.h and seems
to be correct, but struct dinode now contains an int32_t for di_mtime,
not a struct timespec as in former times.

So the question simply is:  Is the dinode structure wrong, with
FreeBSD changes to be brought back from revision 1.4 of dinode.h,
or does traverse.c simple need to collapse the above to:

#define CHANGEDSINCE(dp, t) \
        ((dp)->di_mtime >= (t) || (dp)->di_ctime >= (t))

And be done with it.  Where's the book on this stuff? :-)

					Jordan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199702161152.DAA14051>