Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Nov 2021 03:23:29 GMT
From:      Scott Long <scottl@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: bcce9c5bedfa - main - Fix "set but not used" warnings in the mps driver.
Message-ID:  <202111250323.1AP3NTSh004010@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by scottl:

URL: https://cgit.FreeBSD.org/src/commit/?id=bcce9c5bedfafd6f0f76c022c8a1e45fa8e9fd0a

commit bcce9c5bedfafd6f0f76c022c8a1e45fa8e9fd0a
Author:     Scott Long <scottl@FreeBSD.org>
AuthorDate: 2021-11-25 03:23:02 +0000
Commit:     Scott Long <scottl@FreeBSD.org>
CommitDate: 2021-11-25 03:23:02 +0000

    Fix "set but not used" warnings in the mps driver.
---
 sys/dev/mps/mps_sas.c     | 2 --
 sys/dev/mps/mps_sas_lsi.c | 3 ---
 sys/dev/mps/mps_table.c   | 2 --
 3 files changed, 7 deletions(-)

diff --git a/sys/dev/mps/mps_sas.c b/sys/dev/mps/mps_sas.c
index 6e610c725edb..c54c2a82faff 100644
--- a/sys/dev/mps/mps_sas.c
+++ b/sys/dev/mps/mps_sas.c
@@ -1180,14 +1180,12 @@ static void
 mpssas_logical_unit_reset_complete(struct mps_softc *sc, struct mps_command *tm)
 {
 	MPI2_SCSI_TASK_MANAGE_REPLY *reply;
-	MPI2_SCSI_TASK_MANAGE_REQUEST *req;
 	unsigned int cm_count = 0;
 	struct mps_command *cm;
 	struct mpssas_target *targ;
 
 	callout_stop(&tm->cm_callout);
 
-	req = (MPI2_SCSI_TASK_MANAGE_REQUEST *)tm->cm_req;
 	reply = (MPI2_SCSI_TASK_MANAGE_REPLY *)tm->cm_reply;
 	targ = tm->cm_targ;
 
diff --git a/sys/dev/mps/mps_sas_lsi.c b/sys/dev/mps/mps_sas_lsi.c
index 8cfb1700c705..dc22af1e47d0 100644
--- a/sys/dev/mps/mps_sas_lsi.c
+++ b/sys/dev/mps/mps_sas_lsi.c
@@ -268,9 +268,6 @@ mpssas_fw_work(struct mps_softc *sc, struct mps_fw_event_work *fw_event)
 	}
 	case MPI2_EVENT_SAS_ENCL_DEVICE_STATUS_CHANGE:
 	{
-		Mpi2EventDataSasEnclDevStatusChange_t *data;
-		data = (Mpi2EventDataSasEnclDevStatusChange_t *)
-		    fw_event->event_data;
 		mps_mapping_enclosure_dev_status_change_event(sc,
 		    fw_event->event_data);
 		break;
diff --git a/sys/dev/mps/mps_table.c b/sys/dev/mps/mps_table.c
index e3254570b496..aec97327e6b6 100644
--- a/sys/dev/mps/mps_table.c
+++ b/sys/dev/mps/mps_table.c
@@ -519,12 +519,10 @@ mps_print_sgl(struct mps_softc *sc, struct mps_command *cm, int offset)
 {
 	MPI2_SGE_SIMPLE64 *sge;
 	MPI2_SGE_CHAIN32 *sgc;
-	MPI2_REQUEST_HEADER *req;
 	struct mps_chain *chain = NULL;
 	char *frame;
 	u_int i = 0, flags;
 
-	req = (MPI2_REQUEST_HEADER *)cm->cm_req;
 	frame = (char *)cm->cm_req;
 	sge = (MPI2_SGE_SIMPLE64 *)&frame[offset * 4];
 	printf("SGL for command %p\n", cm);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202111250323.1AP3NTSh004010>