Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 Jul 2026 17:57:34 +0000
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 8aec309852b5 - main - stand: Remove a pointless goto
Message-ID:  <6a6ce20e.3f382.1f114d7@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=8aec309852b5285cfa03424f7776a0bf432dff7a

commit 8aec309852b5285cfa03424f7776a0bf432dff7a
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2026-07-31 17:50:33 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2026-07-31 17:50:33 +0000

    stand: Remove a pointless goto
    
    Commit 505222d35fea removed a batch of code that this goto used to skip
    around.
    
    Reviewed by:    olce, kib, markj
    Fixes:          505222d35fea ("Implement the long-awaited module->file cache database.  A userland tool (kldxref(8)) keeps a cache of what modules and versions are inside what .ko files.  I have tested this on both Alpha and i386.")
    Differential Revision:  https://reviews.freebsd.org/D58539
---
 stand/common/load_elf.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/stand/common/load_elf.c b/stand/common/load_elf.c
index 1c4efb8c4156..97467094750c 100644
--- a/stand/common/load_elf.c
+++ b/stand/common/load_elf.c
@@ -921,9 +921,6 @@ nosyms:
 	if (__elfN(parse_modmetadata)(fp, ef, p_start, p_end) == 0)
 		goto out;
 
-	if (ef->kernel)		/* kernel must not depend on anything */
-		goto out;
-
 out:
 	if (dp)
 		free(dp);


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a6ce20e.3f382.1f114d7>