Date: Mon, 18 Apr 2005 07:14:24 +0200 From: Florent Thoumie <flz@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/audio/timidity++ Makefile distinfo pkg-descr patch-Makefile.in patch-ab patch-ac patch-ad patch-ae Message-ID: <1113801264.729.9.camel@innercity> In-Reply-To: <20050418040436.GA32915@FreeBSD.org> References: <200504121249.j3CCn3Cb034016@repoman.freebsd.org> <200504160243.44701.michaelnottebrock@gmx.net> <20050418040436.GA32915@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Le Lundi 18 avril 2005 à 04:04 +0000, Alexey Dokuchaev a écrit :
> On Sat, Apr 16, 2005 at 02:43:39AM +0200, Michael Nottebrock wrote:
> > On Tuesday, 12. April 2005 14:49, Florent Thoumie wrote:
> >
> > > Log:
> > > - Update to 2.13.2.
> > > - Assign maintainership to nork.
> > > - Global overhaul of the port.
> >
> > PKGNAMESUFFIX:= ${PKGNAMESUFFIX}-esound <- this won't fly with 4-stable's
> > make(1) (will break INDEX for people with esound installed).
>
> BTW, what about dropping package name suffix alteration at all? Or, better,
> can someone explain why `-esound' is so special than most other ports' knobs
> out there?
audio/timidity ++ is a master port that can receive another
PKGNAMESUFFIX. I had 3 choices :
x Making PKGNAMESUFFIX= -esound conditional, depending on
OSVERSION,
x Making PKGNAMESUFFIX= -esound conditional, depending on
whether PKGNAMESUFFIX is already set up or not,
x Removing PKGNAMESUFFIX= -esound.
If you can find a better solution, just propose.
Note: I'm not sure why -esound suffix is so special, but in
comparison of other possible PKGNAMESUFFIX for this, I thought
it wasn't, that's why I just removed it.
--
Florent Thoumie
flz@FreeBSD.org
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)
iD8DBQBCY0IwMxEkbVFH3PQRAmehAJ9zfflK2oLZRKf5Spaj/kIRqwAYbwCeLrP2
ayCq/z7CLFqlWN9YQQTwAYk=
=n3iL
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1113801264.729.9.camel>