Date: Tue, 17 Nov 2009 21:05:02 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: davidxu@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r199465 - head/lib/librt Message-ID: <20091117.210502.-1623813784.imp@bsdimp.com> In-Reply-To: <200911180135.nAI1ZaIe051549@svn.freebsd.org> References: <200911180135.nAI1ZaIe051549@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200911180135.nAI1ZaIe051549@svn.freebsd.org>
David Xu <davidxu@freebsd.org> writes:
: Author: davidxu
: Date: Wed Nov 18 01:35:36 2009
: New Revision: 199465
: URL: http://svn.freebsd.org/changeset/base/199465
:
: Log:
: Fix compiler warnings.
:
: Modified:
: head/lib/librt/sigev_thread.c
:
: Modified: head/lib/librt/sigev_thread.c
: ==============================================================================
: --- head/lib/librt/sigev_thread.c Wed Nov 18 01:13:15 2009 (r199464)
: +++ head/lib/librt/sigev_thread.c Wed Nov 18 01:35:36 2009 (r199465)
: @@ -439,9 +439,9 @@ worker_routine(void *arg)
: {
: struct sigev_node *sn = arg;
:
: - _pthread_cleanup_push(worker_cleanup, sn);
: + pthread_cleanup_push(worker_cleanup, sn);
: sn->sn_dispatch(sn);
: - _pthread_cleanup_pop(1);
: + pthread_cleanup_pop(1);
:
: return (0);
: }
This change causes libthr to be needed now for librt. Before this
wasn't the case, so ntp break on mips now (I haven't looked at other
arcs yet). _pthread_cleanup_pop is exported from libc, while
pthread_cleanup_pop causes __pthread_cleanup_pop_imp to be referenced,
which is defined in libthr.
I guess that's a long way of saying "gee, this seems wrong to me,
please explain what you are fixing better or revert this change,
thanks" :)
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091117.210502.-1623813784.imp>