Date: Sat, 23 Feb 2019 10:08:33 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Ryan Steinmetz <zi@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-svnadmin@freebsd.org Subject: Re: svn commit: r493633 - svnadmin/hooks/scripts Message-ID: <20190223100832.GA23828@FreeBSD.org> In-Reply-To: <201902230159.x1N1x3vr074164@repo.freebsd.org> References: <201902230159.x1N1x3vr074164@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 23, 2019 at 01:59:03AM +0000, Ryan Steinmetz wrote: > New Revision: 493633 > URL: https://svnweb.freebsd.org/changeset/ports/493633 > > Log: > - Make error message useful > > PR: 226864, 231327 > Approved by: portmgr (implicit, noop) > > Modified: > svnadmin/hooks/scripts/verify.py > > + self.do_fail('Do not replace a file, this can lose history. Try: svn cp;svn commit, then add your changes and commit. Path: "%s"\n' % path) There's no need to commit after "svn cp". Also, the whitespace bugs here are preposterous. You should've requested someone to review these changes prior to committing them. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190223100832.GA23828>