Date: Tue, 13 Jan 2015 15:29:24 +0000 From: Rodrigo Osorio <rodrigo@bebik.net> To: Chris H <bsd-lists@bsdforge.com> Cc: freebsd-ports@freebsd.org Subject: Re: getpatch scripit rewroted in plain shell Message-ID: <20150113152914.GA34923@shell.bebik.local> In-Reply-To: <31b09270cbbd866005dca3e1584f3f9c@ultimatedns.net> References: <20150113134931.GA27220@shell.bebik.local> <31b09270cbbd866005dca3e1584f3f9c@ultimatedns.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13/01/15 07:11 -0800, Chris H wrote: > On Tue, 13 Jan 2015 13:49:31 +0000 Rodrigo Osorio <rodrigo@bebik.net> wrote > > > Hi ports :) > > > > For a long time, I was missing some features in the exising getpatch script > > ( svn repo Tools/scripts/getpatch) and since I'm not a py fan boy, I rewrote > > the tool in plain shell. This is its storry.... > > > > The new features are : > > - use the bug id as a directory to store the attachements inside (can be > > turned off) - decide if you want or not obsolete patches (by default is no) > > - an env variable to define where attachements are stored (by default ./) > > - be verbose > > - only uses tools from base > > > > example : > > rodrigo@scotty % printenv GETPATCH_DIR > > /home/rodrigo/patches/ > > > > rodrigo@scotty % getpatch 191840 > > Bug ID: 191840 > > + att-144615: pidgin-gnome-keyring.tar.gz is obsolete, skip > > + att-144641: pidgin-gnome-keyring.tar.gz download success > > + att-144642: pidgin-gnome-keyring-1.20_1.txz download success > > >> Patches stored in /usr/home/rodrigo/patches/191840 > > > > The code is here : http://files.bebik.net/code/getpatch > > > > Suggestions and comments are wellcomed > Looks good. > Your native language appears to be français. :) > I would only offer grammatical changes: > > s/a dedicate/the dedicated/g > > s/dedicate/dedicated/g > > # I try to avoid contractions because some shells trip on the apostrophe. > s/Can\'t/Unable to/g > > s/catched/caught/g > > Bon travail! > > --Chris > > > > Regards, > > - rodrigo > > > > PS: There are room for improvements, I know. Bugzilla request can be reduced > > to a single one but this leads to xml and b64 management in shell, and it > > sounds a little bit insane to me... > > > > _______________________________________________ > > freebsd-ports@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" > > Chris, Thanks for your feedback, I really appreciate your contribution. The file now includes the suggested changes. - rodrigo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150113152914.GA34923>