Date: Tue, 6 Mar 2007 00:06:05 +0100 From: Paolo Pisati <piso@freebsd.org> To: Paolo Pisati <piso@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 115381 for review Message-ID: <20070305230605.GA2510@tin.it> In-Reply-To: <200703052301.l25N1SCK070403@repoman.freebsd.org> References: <200703052301.l25N1SCK070403@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 05, 2007 at 11:01:28PM +0000, Paolo Pisati wrote: > http://perforce.freebsd.org/chv.cgi?CH=115381 > > Change 115381 by piso@piso_newluxor on 2007/03/05 23:01:11 > > Restore the sos's intendation style. > > Affected files ... > > .. //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#7 edit > .. //depot/projects/soc2006/intr_filter/dev/scc/scc_core.c#15 edit > > Differences ... > [snip] > ==== //depot/projects/soc2006/intr_filter/dev/scc/scc_core.c#15 (text) ==== > > @@ -535,8 +535,8 @@ > if (device_get_parent(child) != dev) > return (EINVAL); > > - /* Interrupt handlers must be FAST or MPSAFE. */ > - if ((filter == NULL) && !(flags & INTR_MPSAFE)) > + /* Interrupt handlers must be FILTER or MPSAFE. */ > + if ((ihand != NULL) && !(flags & INTR_MPSAFE)) > return (EINVAL); > > sc = device_get_softc(dev); This should be: o properly check for FILTER or MPSAFE handler. bye, P.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070305230605.GA2510>