Date: Thu, 28 Dec 2006 10:45:15 -0800 From: Julian Elischer <julian@elischer.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_ppp.c ng_ppp.h Message-ID: <459410BB.7000907@elischer.org> In-Reply-To: <20061228133525.GN46380@FreeBSD.org> References: <200612281321.kBSDLsfb022830@repoman.freebsd.org> <20061228133525.GN46380@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Smirnoff wrote: > On Thu, Dec 28, 2006 at 01:21:54PM +0000, Gleb Smirnoff wrote: > T> glebius 2006-12-28 13:21:54 UTC > T> > T> FreeBSD src repository > T> > T> Modified files: > T> sys/netgraph ng_ppp.c ng_ppp.h > T> Log: > T> Before this commit, if the compression is enabled the, ng_ppp(4) > T> node would send every outgoing frame to the "compress" hook. > T> Packets received on the "compress" hook were expected to be > T> compressed and PROT_COMPD tag was put on them unconditionally. > T> > T> After this commit an alternative compression mode can be set. > T> In this mode the node doesn't put the PROT_COMPD, the compressor > T> should put it itself. This is important for such kind of > T> compressors, that can submit uncompressed frames. > T> > T> Before this commit, if the decompression is enabled, the ng_ppp(4) > T> node would send and incoming frame to the "decompress" hook > T> only if it has the PROT_COMPD proto tag on it. > T> > T> After this commit an alternative decompression mode can be set. > T> In this mode the node sends all the incoming packets to the > T> decompression hook. This is important for such kind of compressors > T> that need uncompressed packets too, to keep their library in sync. > T> > T> These new features will be used in new version of mpd4, and in new > T> compressor nodes. > T> > T> Submitted by: Alexander Motin <mav alkar.net> > > This commit obfuscates ng_ppp_input() further. We have plans to > toss some code in the ng_ppp(4), utilizing per-hook receive data > methods to make its input code path more clear for reading. that's why I made per-hook input methods :-) >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?459410BB.7000907>