Date: Fri, 28 Feb 2025 17:37:48 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Daniel Engberg <diizzy@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 34b444edf631 - main - devel/icu: Revert unrelated changes in previous commit Message-ID: <rrg3ug5fj2tu2fipql5df3teglsnk6lx4phjvj6nledacol4w7@bfefc2ukjofy> In-Reply-To: <202502210027.51L0RhmO000119@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Fri 21 Feb 00:27, Daniel Engberg wrote: > The branch main has been updated by diizzy: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=34b444edf6319efbf1ee2c8b75e3e4db1f72378c > > commit 34b444edf6319efbf1ee2c8b75e3e4db1f72378c > Author: Daniel Engberg <diizzy@FreeBSD.org> > AuthorDate: 2025-02-20 23:40:38 +0000 > Commit: Daniel Engberg <diizzy@FreeBSD.org> > CommitDate: 2025-02-20 23:40:42 +0000 > > devel/icu: Revert unrelated changes in previous commit > > Remove unrelated and undocumented changes made in commit > 312c3df64b879c24fafa08ddfcef40b3069be399 > > Approved by: portmgr (blanket) This change has clearly not been approved by portmgr and is not covered by the blanket approval. It is unnecessary and unacceptable. While you may raise concerns with sunpoet about improving his commit logs to better document the reasons behind his changes, many committers, including myself, need to improve the quality of our commit logs. If you have significant issues with sunpoet, please bring them to the attention of portmgr so they can be addressed appropriately. However, this particular change is pointless, hostile, and unacceptable. With my portmgr hat on, Best regards, Bapthome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?rrg3ug5fj2tu2fipql5df3teglsnk6lx4phjvj6nledacol4w7>