Date: Sat, 31 Jan 2026 17:50:11 +0000 From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav <des@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 8a3223b62a15 - stable/14 - mdmfs: Fix soft updates logic Message-ID: <697e40d3.1f9ab.2dcfaeca@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=8a3223b62a15016ad9d17baed393b5c2e8d4bdd4 commit 8a3223b62a15016ad9d17baed393b5c2e8d4bdd4 Author: Dag-Erling Smørgrav <des@FreeBSD.org> AuthorDate: 2026-01-22 18:16:37 +0000 Commit: Dag-Erling Smørgrav <des@FreeBSD.org> CommitDate: 2026-01-31 17:50:03 +0000 mdmfs: Fix soft updates logic Now that newfs(8) has a command-line argument to disable soft updates, use that instead of running tunefs(8) after the fact to turn them off. MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: mckusick, imp Differential Revision: https://reviews.freebsd.org/D54783 (cherry picked from commit 4b9620433855b75989164c1a8a8a2e1a9b5fbff2) --- sbin/mdmfs/mdmfs.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/sbin/mdmfs/mdmfs.c b/sbin/mdmfs/mdmfs.c index ceb33362e627..1b874b1386cc 100644 --- a/sbin/mdmfs/mdmfs.c +++ b/sbin/mdmfs/mdmfs.c @@ -105,7 +105,7 @@ main(int argc, char **argv) bool detach, softdep, autounit, newfs; const char *mtpoint, *size_arg, *skel, *unitstr; char *p; - int ch, idx, rv; + int ch, idx; void *set; unsigned long ul; @@ -344,8 +344,7 @@ main(int argc, char **argv) if (!have_mdtype) mdtype = MD_SWAP; - if (softdep) - argappend(&newfs_arg, "-U"); + argappend(&newfs_arg, softdep ? "-U" : "-u"); if (mdtype != MD_VNODE && !newfs) errx(1, "-P requires a vnode-backed disk"); @@ -358,13 +357,6 @@ main(int argc, char **argv) do_mdconfig_attach(mdconfig_arg, mdtype); if (newfs) do_newfs(newfs_arg); - if (!softdep) { - rv = run(NULL, "%s %s /dev/%s%d", _PATH_TUNEFS, - "-n disable", mdname, unit); - if (rv) - errx(1, "tunefs exited %s %d", run_exitstr(rv), - run_exitnumber(rv)); - } do_mount_md(mount_arg, mtpoint); }home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?697e40d3.1f9ab.2dcfaeca>