Date: Mon, 22 Aug 2011 22:08:24 +0100 From: Chris Rees <crees@freebsd.org> To: "Joseph S. Atkinson" <jsa@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org, Joe Marcus Clarke <marcus@freebsd.org>, Rene Ladan <rene@freebsd.org>, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/www/chromium Makefile Message-ID: <CADLo83_cBjSkjqt2dFbC-PjuMJipRet4d8jBcTEaMrCdtwgQ4g@mail.gmail.com> In-Reply-To: <4E52C169.2080305@FreeBSD.org> References: <201108211100.p7LB0cB7060742@repoman.freebsd.org> <CADLo838r7ksFKTjB24NBVTtnyDaf54jdz9aQ9Ggb22CtsvA9ng@mail.gmail.com> <20110821114454.GA77777@FreeBSD.org> <CADLo83-G2ofiaLZiTA_%2BB2FBTAw-AUw2%2BGHWfEo%2BMno7QJXeRQ@mail.gmail.com> <20110821115214.GA85711@FreeBSD.org> <20110821120013.GA86358@FreeBSD.org> <CADLo83-wjXWb3=CH6t5v_H3mUhR0ODZ39wqfDpLY29w-_=kXOw@mail.gmail.com> <4E52C169.2080305@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22 Aug 2011 21:51, "Joseph S. Atkinson" <jsa@freebsd.org> wrote: > > On 08/21/2011 09:13, Chris Rees wrote: >> >> >> On 21 Aug 2011 13:00, "Alexey Dokuchaev" <danfe@freebsd.org >> <mailto:danfe@freebsd.org>> wrote: >> > >> > On Sun, Aug 21, 2011 at 11:52:14AM +0000, Alexey Dokuchaev wrote: >> > > On Sun, Aug 21, 2011 at 12:48:38PM +0100, Chris Rees wrote: >> > > > I'd agree on FILESDIR. >> > > > >> > > > Anyone have a problem with adding a section on >> > > > wiki/PortsLongtermTargets about ports that use PATCHDIR? This >> > > > inconsistency is a little strange. >> > > >> > > Oh, please do. This inconsistency is not just strange, but rather annoying. >> > >> > As for the strange part, it seems like historical left-over from times when >> > ports had "patches" directory (I vaguelly recall the OpenBSD still does it >> > these days). Since FreeBSD had standardized on "files" long time ago, bpm >> > should stop using PATCHDIR and replace it with FILESDIR). Ditto for the >> > ports, of course. >> > >> >> PR filed at http://www.freebsd.org/cgi/query-pr.cgi?pr=159970 thanks for the >> motivation ;) >> >> Chris >> > > I will ping marcus and have him add a bit to portlint(1) and maybe check for hardcoding of files/ as well. > Make a patch you lazy git :P Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83_cBjSkjqt2dFbC-PjuMJipRet4d8jBcTEaMrCdtwgQ4g>