Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Feb 2022 13:33:38 -0500
From:      Mark Johnston <markj@freebsd.org>
To:        Helge Oldach <freebsd@oldach.net>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org
Subject:   Re: git: 5fa005e91560 - stable/13 - exec: Reimplement stack address randomization
Message-ID:  <Yg1Dgvi7dZtaQBDM@nuc>
In-Reply-To: <202202161830.21GIUNIf004834@nuc.oldach.net>
References:  <202202161759.21GHxF5W050008@gitrepo.freebsd.org> <202202161830.21GIUNIf004834@nuc.oldach.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 16, 2022 at 07:30:23PM +0100, Helge Oldach wrote:
> Mark Johnston wrote on Wed, 16 Feb 2022 18:59:15 +0100 (CET):
> > The branch stable/13 has been updated by markj:
> >=20
> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D5fa005e91560785dad5183db=
080209447afde3c2
> >=20
> > commit 5fa005e91560785dad5183db080209447afde3c2
> > Author:     Mark Johnston <markj@FreeBSD.org>
> > AuthorDate: 2022-01-17 16:42:56 +0000
> > Commit:     Mark Johnston <markj@FreeBSD.org>
> > CommitDate: 2022-02-16 16:55:03 +0000
> >=20
> >     exec: Reimplement stack address randomization
> >    =20
>=20
> --- kern_exec.o ---
> cc -target x86_64-unknown-freebsd13.0 --sysroot=3D/usr/obj/usr/src/amd64.=
amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe  -fno-str=
ict-aliasing  -g -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/in=
clude -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS =
-include opt_global.h -fno-common    -fno-omit-frame-pointer -mno-omit-leaf=
-frame-pointer -MD  -MF.depend.kern_exec.o -MTkern_exec.o -fdebug-prefix-ma=
p=3D./machine=3D/usr/src/sys/amd64/include -fdebug-prefix-map=3D./x86=3D/us=
r/src/sys/x86/include -mcmodel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -ms=
oft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-p=
rotector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmis=
sing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__p=
rintf__=3D__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-opt=
ion -Wno-unknown-pragmas -Wno-error=3Dtautological-compare -Wno-error=3Demp=
ty-body -Wno-error=3Dparentheses-equality -Wno-error=3Dunused-function -Wno=
-error=3Dpointer-sign -Wno-error=3Dshift-negative-value -Wno-address-of-pac=
ked-member -Wno-error=3Dunused-but-set-variable -Wno-format-zero-length   -=
mno-aes -mno-avx  -std=3Diso9899:1999 -Werror  /usr/src/sys/kern/kern_exec.c
> /usr/src/sys/kern/kern_exec.c:1197:9: error: returning 'void' from a func=
tion with incompatible result type 'int'
>         return (sv->sv_onexec !=3D NULL ? sv->sv_onexec(p, imgp) : 0);

Thanks, fixed now.  I hit this when testing but failed to commit the
fixups before pushing.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Yg1Dgvi7dZtaQBDM>