Date: Sun, 21 Nov 2004 13:11:46 -0500 From: James <james@towardex.com> To: gnn@freebsd.org Cc: James <haesu@towardex.com> Subject: Re: Initial review request for IPv6 Fast Forwarding and IP6STEALTH Message-ID: <20041121181146.GA76095@scylla.towardex.com> In-Reply-To: <m2u0rj86tx.wl@minion.local.neville-neil.com> References: <20041115222310.GA93130@scylla.towardex.com> <m2u0rj86tx.wl@minion.local.neville-neil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 21, 2004 at 09:12:10AM -0800, gnn@freebsd.org wrote: > Hi James, > > A few comments for you: Hi George, Thanks for your good comments and catch on the line 223! I'll integreate the fixes soon for the final draft. -J > > Issues found: > ip6_forward_rt is a global value that is used without locking > ASSERTS still include the old name apc_inet6_fastfwd > Stats are updated directly but I don't think we lock those yet. > Don't define M2MMAX in line, put it outside with a comment. > If the mbuf is already freed then how can we safely use m->m_pkthdr.rcvif? at line 223 > Improve the indenting in the commented case at line 298. I understand the idea, and it's good, but it's a bit confusing to read. > Remove #if code at 553 which is specific to the APC product. > > Later, > George -- James Jun TowardEX Technologies, Inc. Technical Lead Boston IPv4/IPv6 Web Hosting, Colocation and james@towardex.com Network design/consulting & configuration services cell: 1(978)-394-2867 web: http://www.towardex.com , noc: www.twdx.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041121181146.GA76095>