Date: Thu, 1 Aug 2024 18:22:17 +0200 From: Alfonso Sabato Siciliano <alfix86@gmail.com> To: Current FreeBSD <freebsd-current@freebsd.org> Cc: Gleb Smirnoff <glebius@freebsd.org>, "Alfonso S. Siciliano" <asiciliano@freebsd.org>, kevans@freebsd.org, Cy.Schubert@cschubert.com Subject: Re: July 2024 stabilization week Message-ID: <CAPJrGM3CpZzOzpNC1yEMEWAtfzBX-PXbRtHAPd3s53x0OpEKXQ@mail.gmail.com> In-Reply-To: <07914356-a21d-4534-b5a4-2e01779b6dc3@FreeBSD.org> References: <Zp4Riz2GBDYGpvoW@cell.glebi.us> <ZqAU-z0Odgh19icf@cell.glebi.us> <ZqlGcB-QrI-9vUVF@cell.glebi.us> <20240730211642.DF1B97E@slippy.cwsent.com> <4a36dfb3-c0ec-4bd0-a049-8f2563f6bc8c@FreeBSD.org> <ZqqRBwdszMyzofDf@cell.glebi.us> <07914356-a21d-4534-b5a4-2e01779b6dc3@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, 31 Jul 2024 at 21:52, Kyle Evans <kevans@freebsd.org> wrote: > On 7/31/24 14:31, Gleb Smirnoff wrote: > > On Tue, Jul 30, 2024 at 05:05:33PM -0500, Kyle Evans wrote: > > K> > > commit ce220b82ad546d3518a805750e5ee6add73f1fbf > > K> > > Author: Alfonso Siciliano <alf.siciliano@gmail.com> > > K> > > Date: Sat May 25 02:42:46 2024 +0200 > > K> > > > > K> > > change: --form and --mixedgauge do not print field input to > output if <fi > > K> > > eldlen> <= 0 > > K> > > > > K> > > > > K> > > That means if you have any scripting using 'bsddialog --form' > with readonly > > K> > > values, you would need to adjust your scripts, otherwise your > variables would > > K> > > be messed up, leading to any possible kind of bugs. > > K> > > > K> > I can't find this revision. > > K> > > > K> > slippy$ git log ce220b82ad546d3518a805750e5ee6add73f1fbf > > K> > fatal: bad object ce220b82ad546d3518a805750e5ee6add73f1fbf > > K> > slippy$ > > K> > > > K> > To verify that my repo wasn't damaged in any way I cloned a fresh > new repo > > K> > from git.freebsd.org. I still can't list that revision. > > K> > > > K> > > K> It's a bsddialog commit, since the full history isn't preserved in > vendor > > K> imports for bsddialog > > K> > > K> > https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf > > > > btw, I'd suggest to switch to subtree merges for future bsddialog > imports, so > > that full commit history is preserved. I can help with that, if needed. > > > > Sorry, to be a bit pedantic: the way it's managed now is still a subtree > merge, the difference is what's in the vendor branch that's merged in > (full history vs. release diffs). > > > Can you please ack that POLA breakage will be noted in the Release Notes > of > > 15.0 and won't be merged to 14.x? > > > I don't maintain bsddialog imports, just the one that fixed an immediate > issue for the work I was doing, but Alfonso noted in response to a > private e-mail thread you started that he'll do both. He hasn't yet > responded to current@ as stated in that e-mail, though, AFAICT. > > Thank you for the testing and the report, Of course I' ll add an entry to src/RELNOTES, new bsddialog shall not be merged to 14.0. Anyway, this change is not related to bsddialog 1.0.4 and to the recent kevans' import. I changed --form outputs in bsddialog 1.0.2 and 1.0.3, imported in CURRENT May 2024. I changed to restore the "old" (LGPL) dialog(1) behavior to avoid bsdinstall-networking-scripts faults (we have a discussion in current@ "bsdinstall wifi setup is broken on CURRENT" and some review). It is not a "full history" but I wrote rationale and FreeBSD notes in the commit messages: https://cgit.freebsd.org/src/tag/?h=vendor/bsddialog/1.0.3 https://cgit.freebsd.org/src/tag/?h=vendor/bsddialog/1.0.2 Also I maintain a CHANGELOG, src/contrib/bsddialog/CHANGELOG. Alfonso [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 31 Jul 2024 at 21:52, Kyle Evans <<a href="mailto:kevans@freebsd.org">kevans@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 7/31/24 14:31, Gleb Smirnoff wrote:<br> > On Tue, Jul 30, 2024 at 05:05:33PM -0500, Kyle Evans wrote:<br> > K> > > commit ce220b82ad546d3518a805750e5ee6add73f1fbf<br> > K> > > Author: Alfonso Siciliano <<a href="mailto:alf.siciliano@gmail.com" target="_blank">alf.siciliano@gmail.com</a>><br> > K> > > Date: Sat May 25 02:42:46 2024 +0200<br> > K> > ><br> > K> > > change: --form and --mixedgauge do not print field input to output if <fi<br> > K> > > eldlen> <= 0<br> > K> > ><br> > K> > ><br> > K> > > That means if you have any scripting using 'bsddialog --form' with readonly<br> > K> > > values, you would need to adjust your scripts, otherwise your variables would<br> > K> > > be messed up, leading to any possible kind of bugs.<br> > K> ><br> > K> > I can't find this revision.<br> > K> ><br> > K> > slippy$ git log ce220b82ad546d3518a805750e5ee6add73f1fbf<br> > K> > fatal: bad object ce220b82ad546d3518a805750e5ee6add73f1fbf<br> > K> > slippy$<br> > K> ><br> > K> > To verify that my repo wasn't damaged in any way I cloned a fresh new repo<br> > K> > from <a href="http://git.freebsd.org" rel="noreferrer" target="_blank">git.freebsd.org</a>. I still can't list that revision.<br> > K> ><br> > K><br> > K> It's a bsddialog commit, since the full history isn't preserved in vendor<br> > K> imports for bsddialog<br> > K><br> > K> <a href="https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf" rel="noreferrer" target="_blank">https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf</a><br>; > <br> > btw, I'd suggest to switch to subtree merges for future bsddialog imports, so<br> > that full commit history is preserved. I can help with that, if needed.<br> > <br> <br> Sorry, to be a bit pedantic: the way it's managed now is still a subtree <br> merge, the difference is what's in the vendor branch that's merged in <br> (full history vs. release diffs).<br> <br> > Can you please ack that POLA breakage will be noted in the Release Notes of<br> > 15.0 and won't be merged to 14.x?<br> > <br> I don't maintain bsddialog imports, just the one that fixed an immediate <br> issue for the work I was doing, but Alfonso noted in response to a <br> private e-mail thread you started that he'll do both. He hasn't yet <br> responded to current@ as stated in that e-mail, though, AFAICT.<br> <br></blockquote><div><br></div><div><br></div><div>Thank you for the testing and the report,<br><br>Of course I' ll add an entry to src/RELNOTES, new bsddialog shall not be<br>merged to 14.0.<br><br>Anyway, this change is not related to bsddialog 1.0.4 and to the recent<br>kevans' import. I changed --form outputs in bsddialog 1.0.2 and 1.0.3,<br>imported in CURRENT May 2024. I changed to restore the "old" (LGPL)<br>dialog(1) behavior to avoid bsdinstall-networking-scripts faults<br>(we have a discussion in current@ "bsdinstall wifi setup is broken on<br>CURRENT" and some review).<br>It is not a "full history" but I wrote rationale and FreeBSD notes in<br>the commit messages:<br><a href="https://cgit.freebsd.org/src/tag/?h=vendor/bsddialog/1.0.3">https://cgit.freebsd.org/src/tag/?h=vendor/bsddialog/1.0.3</a><br><a href="https://cgit.freebsd.org/src/tag/?h=vendor/bsddialog/1.0.2">https://cgit.freebsd.org/src/tag/?h=vendor/bsddialog/1.0.2</a><br>Also I maintain a CHANGELOG, src/contrib/bsddialog/CHANGELOG.<br><br><br>Alfonso<br></div><div><br></div><div> </div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPJrGM3CpZzOzpNC1yEMEWAtfzBX-PXbRtHAPd3s53x0OpEKXQ>