Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Sep 2013 23:01:32 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        John-Mark Gurney <jmg@FreeBSD.org>, re@freebsd.org
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r255187 - in head/sys: conf crypto/aesni modules/aesni
Message-ID:  <20130910060132.GA61541@dragon.NUXI.org>
In-Reply-To: <201309031831.r83IVNkh026523@svn.freebsd.org>
References:  <201309031831.r83IVNkh026523@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 03, 2013 at 06:31:23PM +0000, John-Mark Gurney wrote:
> Log:
>   Use the fact that the AES-NI instructions can be pipelined to improve
>   performance... Use SSE2 instructions for calculating the XTS tweek
>   factor...  Let the compiler do more work and handle register allocation
>   by using intrinsics, now only the key schedule is in assembly...

Hi John-Mark,
Unfortunately this does not work with /usr/bin/gcc (which I still use as
/usr/bin/cc on this old IBM T60 laptop due to clang's enormous pestimation
on 'make world' and build times.

Please fix this ASAP or back it out out of 10-CURRENT as it does not work
with /usr/bin/gcc:

1. /usr/bin/gcc cannot handle the "-maes" option.
I committed r255440 to address this.

2. /usr/src/sys/modules/aesni/../../crypto/aesni/aesencdec.h:30:23: error: wmmintrin.h: No such file or directory
and then a cascade of errors follow.

For now, I've sent a patch to re@ for approval to remove the 'aesni'
module from the build if not using clang.  But the LINT build is
still broken with /usr/bin/gcc.


>   Replace .byte hard coded instructions w/ the proper instructions now
>   that both clang and gcc support them...

Is this out-of-tree latest GCC that supports this?

thanks,
-- 
-- David  (obrien@FreeBSD.org)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130910060132.GA61541>