Date: Mon, 24 Jul 2017 17:20:01 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r321444 - head/etc Message-ID: <CD690C84-623A-46D2-AE9A-A6D3DE7D76EA@gmail.com> In-Reply-To: <5890e09f-8983-f458-34cf-3107f288edc1@FreeBSD.org> References: <201707242357.v6ONvhJA063824@repo.freebsd.org> <5890e09f-8983-f458-34cf-3107f288edc1@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_12DCF526-51C1-4587-97BB-6BAD3F69993B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 24, 2017, at 17:17, Bryan Drewery <bdrewery@FreeBSD.org> wrote: >=20 > On 7/24/2017 4:57 PM, Ngie Cooper wrote: >> Author: ngie >> Date: Mon Jul 24 23:57:43 2017 >> New Revision: 321444 >> URL: https://svnweb.freebsd.org/changeset/base/321444 >>=20 >> Log: >> Remove ${MTREE} and leverage etc/mtree/Makefile instead with >> "make distribution". >>=20 >> This also fixes the fact that BSD.debug.dist was being installed = if/when >> ${MK_DEBUG_FILES} !=3D "no" before this commit. >=20 > This was intentional, see r279248. Ok. It would have been nice if there had been a comment added noting = that it was being unconditionally installed for a reason. I=E2=80=99ll add a relevant comment to etc/mtree/Makefile and restore = the previous behavior (it was silly having duplicative logic in two = places, since etc/mtree/Makefile wasn=E2=80=99t actually being used). Thanks, -Ngie --Apple-Mail=_12DCF526-51C1-4587-97BB-6BAD3F69993B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZdo6xAAoJEPWDqSZpMIYVJZgP/RQuVoCF6bw1DvbM5P799khr VsVov5H+T8NjTBOvMSyrV0GYQNSE+G1JNQXnY30Lo6AQWfKyxmIOiFbSpbiEqnN6 /kcRDTCUcwTr5pxd78XTztWWaPfYWf6S0ZuSmHJAqgUNQSq9Kqk9AdEcyFuW09GI uNu2+kaLBh77gtPvB86TuLmx6clD/dyXfxSK5kitcJfpALvEky4VTq29/Zs6gu6b wYmkGj6tOmxTEK2ghTaH4JTzcXcq6U/I/j1aYWXWwQAiw2ABfQmON7NreEaRdeDN yuYFdLm6O05yb6cgprDJT9jUc4Yw4cTBl/xnGwpxxZrWdsGI2ZKu5Hvik5qtoIyc gelnaT1KHqW05WEzMLK+6bNUYYrIFxpVYNtkeBOvTZiKZtIAn5b/h6KexittZs4x gDRAVMF7caQsVuhGAlUEHvLHSclQa591MBQa4SL2r6/1bYtkscWx4g4hlRYilHb/ wOwm5HSfL0WTXF467bzhdAdyVhWYRp34Zv4BG48b0X0KgVhYwltJH9HRpL3AAOc5 KqqJsxMGaBW1X/Fi5hp1D18bJYxLklD1LB6h/mJXTGO+BnMoy3lcS7BmnCkz+Qdc 49+kgZcsxDncTjKPlBuNkcSbFchPYRelCEmpocpMBDO8AmXM0DBl+2nXFkXXcFbg Fs1MItDHEKutU+czLaPx =X+6O -----END PGP SIGNATURE----- --Apple-Mail=_12DCF526-51C1-4587-97BB-6BAD3F69993B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CD690C84-623A-46D2-AE9A-A6D3DE7D76EA>