Date: Sun, 18 Nov 2012 16:41:56 +0000 From: Chris Rees <utisoft@gmail.com> To: Hiroki Sato <hrs@freebsd.org> Cc: freebsd-rc@freebsd.org Subject: Re: bin/165477: [rc] dhclient is run twice Message-ID: <CADLo83-FbjpGBUdBqOxPqpW%2B48RHBmEqTopKC1MUPN0EX1_b7A@mail.gmail.com> In-Reply-To: <20121119.001726.1901703543569641080.hrs@allbsd.org> References: <201211181450.qAIEo0L7037418@freefall.freebsd.org> <20121119.001726.1901703543569641080.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 Nov 2012 15:17, "Hiroki Sato" <hrs@freebsd.org> wrote:
>
> Chris Rees <crees@freebsd.org> wrote
> in <201211181450.qAIEo0L7037418@freefall.freebsd.org>:
>
> cr> The following reply was made to PR bin/165477; it has been noted by
GNATS.
> cr>
> cr> From: Chris Rees <crees@FreeBSD.org>
> cr> To: Hiroki Sato <hrs@freebsd.org>
> cr> Cc: wblock@freebsd.org, "freebsd-rc@freebsd.org" <
freebsd-rc@freebsd.org>,
> cr> "bug-followup@freebsd.org" <bug-followup@freebsd.org>
> cr> Subject: Re: bin/165477: [rc] dhclient is run twice
> cr> Date: Sun, 18 Nov 2012 14:40:00 +0000
> cr>
> cr> On 17 November 2012 22:59, Hiroki Sato <hrs@freebsd.org> wrote:
> cr> >
> cr> > I think it is safe to remove the warning message when
rc_quiet=YES.
> cr> > What do you think about the attached patch?
> cr>
> cr> I had originally considered that, but it then makes dhclient behave
> cr> differently from other scripts; nothing else respects rc_quiet in
this
> cr> fashion;
> cr>
> cr> from rc.subr:
> cr> start)
> cr> if [ -z "$rc_fast" -a -n "$rc_pid" ]; then
> cr> echo 1>&2 "${name} already running?
> cr> (pid=$rc_pid)."
> cr> return 1
> cr> fi
> cr> and
> cr>
> cr> [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd
quietstart
> cr> musicpd already running? (pid=83847).
>
> I cannot understand why the dhclient script behaves differently from
> the others after patching rc.subr. Did you read the attached patch
> in my previous email?
I read the patch, but not the filename-- I'm sorry that Sunday afternoons
are clearly not a good time for me to review code :(
If you want to respect rc_quiet in rc.subr for the already running case,
then I think that's fine.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-FbjpGBUdBqOxPqpW%2B48RHBmEqTopKC1MUPN0EX1_b7A>