Date: Mon, 7 Dec 2020 14:44:40 -0600 From: Kyle Evans <kevans@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Steve Wills <swills@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat Message-ID: <CACNAnaHmrj6aZacAoUW-C0OfaYxiYu2YyG9X9Svrg1Xvciddzw@mail.gmail.com> In-Reply-To: <63620a02-ba74-7728-385d-41f473d80afe@FreeBSD.org> References: <202011250010.0AP0AtH3061986@repo.freebsd.org> <9f48b622-2596-f3c4-0aff-f0b57e8022ea@FreeBSD.org> <43f82b24-a1d0-8e48-a405-58e8bbda0c12@FreeBSD.org> <CACNAnaH8ZhXcS-UJSvKKqeR8wmuA3Fbt3ntVeTX=5Nc2wYTJew@mail.gmail.com> <7506dfff-0d35-b71d-fedf-b9c0300205a2@FreeBSD.org> <CACNAnaHd6=HtsOwZOOsFStCRRj7k1c9nQnLFQRogPzkKNWc6zQ@mail.gmail.com> <63620a02-ba74-7728-385d-41f473d80afe@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 7, 2020 at 2:41 PM John Baldwin <jhb@freebsd.org> wrote: > > On 12/7/20 12:37 PM, Kyle Evans wrote: > > On Mon, Dec 7, 2020 at 2:36 PM John Baldwin <jhb@freebsd.org> wrote: > >> > >> qemu-user uses this flag? What on earth can it be using it for? > >> > > > > It was faithfully responding that it wasn't implemented to any > > target-application usage, apparently. :-) > > I mean, it is only a flag in the struct kinfo_file flags field. Even > if it is doing some kind of compat shim for kinfo_file it should just > copy the flags field across, not be checking any of the bits. Does it > try to log the type of a file descriptor in debug traces perhaps? > Apparently we were just that convinced we needed to enumerate the values we didn't have to touch, see: https://github.com/seanbruno/qemu-bsd-user/pull/150/files -> it was actually CRIOGET that we referenced for the sole purpose of declaring it unsupported.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHmrj6aZacAoUW-C0OfaYxiYu2YyG9X9Svrg1Xvciddzw>