Date: Fri, 26 Feb 2021 08:45:23 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r363263 - in head/lib/csu: . common Message-ID: <1b60cbd0-c891-7d44-c0d3-809586b16807@FreeBSD.org> In-Reply-To: <CACNAnaG02nyqB=QO5ycfDoRpofBKau05U0CmxQKp7ty4BieEaQ@mail.gmail.com> References: <202007162158.06GLwh9N034510@repo.freebsd.org> <CACNAnaG02nyqB=QO5ycfDoRpofBKau05U0CmxQKp7ty4BieEaQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/26/21 6:02 AM, Kyle Evans wrote: > On Thu, Jul 16, 2020 at 4:58 PM John Baldwin <jhb@freebsd.org> wrote: >> >> Author: jhb >> Date: Thu Jul 16 21:58:43 2020 >> New Revision: 363263 >> URL: https://svnweb.freebsd.org/changeset/base/363263 >> >> Log: >> Include ABI note tag in shared libraries. >> >> Split the ELF feature note into a separate file that is linked into >> *crt1.o the same as crtbrand.S was before. crtbrand.o is now linked >> into crti.o on all platforms in addition to *crt1.o. >> > > This is pretty handy; any chance we can backport this series for 12.3? So there is an issue I need to resolve in that the notes can get lost if you use --gc-sections which LLVM does when building the cross toolchain (so the trick of using .comdat for notes doesn't end up working out). Right now it only fully breaks RISC-V since all the other arches still have FreeBSD set as the ELF OSABI in the ELF header. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1b60cbd0-c891-7d44-c0d3-809586b16807>