Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Sep 2018 12:47:31 -0400
From:      "Jason E. Hale" <jhale@freebsd.org>
To:        db@freebsd.org
Cc:        ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r480915 - in head/comms: . apitran
Message-ID:  <CAJE75NHSL2GQQwA3CmYEtctA76uTAm3p6UcB2rjg2CG=Ru=6vA@mail.gmail.com>
In-Reply-To: <201809291950.w8TJoxrM093616@repo.freebsd.org>
References:  <201809291950.w8TJoxrM093616@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 29, 2018 at 3:51 PM Diane Bruce <db@freebsd.org> wrote:
>
> Author: db
> Date: Sat Sep 29 19:50:58 2018
> New Revision: 480915
> URL: https://svnweb.freebsd.org/changeset/ports/480915
>
> Log:
>   A Linux toolkit for handling signals over the automatric picture
>   transmission (APT) protocol.
>
>   ## Intro to Automatic Picture Transmission
>   Automatic picture transmission (APT) is an analog image transmission format
>   developed for use on weather satellites in the 1960s. While only three
>   modern satellites, NOAA 15, NOAA 18, and NOAA 19, transmit on the APT
>   protocol, building a reception station is cheap and simple. The images can
>   be quite high qualitythey natively have a resolution of
>   4 km/px. It is reasonable to expect at least one good-quality satellite
>   pass (and, thereby, opportunity for image downlink) per day.
>
>   WWW: https://github.com/rsj56/apitran
>
> Added:
>   head/comms/apitran/
>   head/comms/apitran/Makefile   (contents, props changed)
>   head/comms/apitran/distinfo   (contents, props changed)
>   head/comms/apitran/pkg-descr   (contents, props changed)
>   head/comms/apitran/pkg-plist   (contents, props changed)
> Modified:
>   head/comms/Makefile
>
> Modified: head/comms/Makefile
> ==============================================================================
> --- head/comms/Makefile Sat Sep 29 19:09:29 2018        (r480914)
> +++ head/comms/Makefile Sat Sep 29 19:50:58 2018        (r480915)
> @@ -8,6 +8,7 @@
>      SUBDIR += aldo
>      SUBDIR += amtterm
>      SUBDIR += anyremote
> +    SUBDIR += apitran
>      SUBDIR += aprsd
>      SUBDIR += atslog
>      SUBDIR += bfhist
>
> Added: head/comms/apitran/Makefile
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/comms/apitran/Makefile Sat Sep 29 19:50:58 2018        (r480915)
> @@ -0,0 +1,46 @@
> +# $FreeBSD$
> +
> +PORTNAME=      apitran
> +PORTVERSION=   g20180926
> +CATEGORIES=    comms astro hamradio python
> +PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
> +
> +MAINTAINER=    hamradio@FreeBSD.org
> +COMMENT=       Toolkit to handle the automatic picture transmission protocol
> +
> +LICENSE=       GPLv3
> +LICENSE_FILE=  ${WRKSRC}/LICENSE
> +
> +BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}tkinter>0:x11-toolkits/py-tkinter@${PY_FLAVOR} \
> +       ${PYTHON_PKGNAMEPREFIX}scipy>0:science/py-scipy@${PY_FLAVOR} \
> +       ${PYTHON_PKGNAMEPREFIX}pillow>0:graphics/py-pillow@${PY_FLAVOR} \
> +       ${PYNUMPY}

These are all RUN_DEPENDS. Please whitespace align these, as well.

> +RUN_DEPENDS=   sox:audio/sox \
> +               display:graphics/ImageMagick
> +
> +USES=          python shebangfix

python:run

> +USE_GITHUB=    yes
> +GH_ACCOUNT=    rsj56
> +GH_PROJECT=    apitran
> +GH_TAGNAME=    d209347
> +#25379d9b681f434145fde9dbbdb3c5ae3
> +#GH_TAGNAME=   d20934725379d9b681f434145fde9dbbdb3c5ae3

These commented out things should probably be removed.

> +
> +SHEBANG_FILES= apitran

> +USE_PYTHON=    autoplist

autoplist can only be used with distutils and you already have a
pkg-plist. Please remove.

> +
> +do-build:
> +

Remove empty do-build target and use NO_BUILD=yes instead. Also add NO_ARCH=yes.

> +do-install:
> +       ${INSTALL_SCRIPT} ${WRKSRC}/apitran ${STAGEDIR}${PREFIX}/bin
> +       ${MKDIR} ${STAGEDIR}${DOCSDIR}

> +       cd ${WRKSRC}

cd ${WRKSRC} Why? Please remove.

> +.for f in NOAA_APT_Frame_Format.gif README.md
> +       ${INSTALL_DATA} ${WRKSRC}/$f ${STAGEDIR}${DOCSDIR}
> +       ${MKDIR} ${STAGEDIR}${EXAMPLESDIR}

MKDIR should not be in the for loop.

> +.endfor
> +.for f in ex_1ch_11025.png ex_2ch_48000.png ex_2ch_48000.wav
> +       ${INSTALL_DATA} ${WRKSRC}/Examples/$f ${STAGEDIR}${EXAMPLESDIR}
> +.endfor
> +
> +.include <bsd.port.mk>
>
> Added: head/comms/apitran/distinfo
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/comms/apitran/distinfo Sat Sep 29 19:50:58 2018        (r480915)
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1538226743
> +SHA256 (rsj56-apitran-g20180926-d209347_GH0.tar.gz) = 65e2d90dd0077d3a837afaaed98b2f51fe2fceb074e15b9358381a8d61b785b6
> +SIZE (rsj56-apitran-g20180926-d209347_GH0.tar.gz) = 57106527
>
> Added: head/comms/apitran/pkg-descr
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/comms/apitran/pkg-descr        Sat Sep 29 19:50:58 2018        (r480915)
> @@ -0,0 +1,13 @@
> +A Linux toolkit for handling signals over the automatric picture

Typo: automatric -> automatic
Should probably omit Linux reference

> +transmission (APT) protocol.
> +
> +## Intro to Automatic Picture Transmission
> +Automatic picture transmission (APT) is an analog image transmission format
> +developed for use on weather satellites in the 1960s. While only three
> +modern satellites, NOAA 15, NOAA 18, and NOAA 19, transmit on the APT
> +protocol, building a reception station is cheap and simple. The images can
> +be quite high qualitythey natively have a resolution of

Typo: qualitythey -> quality; they

> +4 km/px. It is reasonable to expect at least one good-quality satellite
> +pass (and, thereby, opportunity for image downlink) per day.
> +
> +WWW: https://github.com/rsj56/apitran
>
> Added: head/comms/apitran/pkg-plist
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/comms/apitran/pkg-plist        Sat Sep 29 19:50:58 2018        (r480915)
> @@ -0,0 +1,6 @@
> +bin/apitran
> +%%DOCSDIR%%/NOAA_APT_Frame_Format.gif
> +%%DOCSDIR%%/README.md
> +%%EXAMPLESDIR%%/ex_1ch_11025.png
> +%%EXAMPLESDIR%%/ex_2ch_48000.png
> +%%EXAMPLESDIR%%/ex_2ch_48000.wav
>

Maybe use PORTDOCS/PORTEXAMPLES macros in the Makefile and
DOCS/EXAMPLES options. That wav file is 96 MB by itself and users with
limited space may want a way to not  install it.

-Jason



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NHSL2GQQwA3CmYEtctA76uTAm3p6UcB2rjg2CG=Ru=6vA>