Date: Tue, 12 Dec 2017 05:49:53 -0700 From: Warner Losh <imp@bsdimp.com> To: Antoine Brodin <antoine@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326792 - head/stand/uboot/common Message-ID: <CANCZdfrja83nEyycA1NOU9LJAO59_PHbbnPRhiuV-x3BWTv2=g@mail.gmail.com> In-Reply-To: <201712120946.vBC9krNL075725@repo.freebsd.org> References: <201712120946.vBC9krNL075725@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This commit message sucks. Please use a more descriptive one in the future like "catch up to change rXXXXX that remove the argument from interact." If you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. Your message is utterly useless. It doesn't even say what arch is broken. Warner Warner On Dec 12, 2017 1:47 AM, "Antoine Brodin" <antoine@freebsd.org> wrote: > Author: antoine > Date: Tue Dec 12 09:46:53 2017 > New Revision: 326792 > URL: https://svnweb.freebsd.org/changeset/base/326792 > > Log: > Attempt to unbreak buildworld > > Modified: > head/stand/uboot/common/main.c > > Modified: head/stand/uboot/common/main.c > ============================================================ > ================== > --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 > (r326791) > +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 > (r326792) > @@ -500,7 +500,7 @@ main(int argc, char **argv) > archsw.arch_readin = uboot_readin; > archsw.arch_autoload = uboot_autoload; > > - interact(NULL); /* doesn't return */ > + interact(); /* doesn't return */ > > return (0); > } > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrja83nEyycA1NOU9LJAO59_PHbbnPRhiuV-x3BWTv2=g>