Date: Mon, 14 Mar 2011 12:05:27 GMT From: Gerald Pfeifer <gerald@pfeifer.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/155550: portlint shall warn about CPPFLAGS being passed to CONFIGURE_ENV and MAKE_ENV Message-ID: <201103141205.p2EC5RBA066687@ref8-amd64.freebsd.org> Resent-Message-ID: <201103141210.p2ECACfV061670@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 155550
>Category: ports
>Synopsis: portlint shall warn about CPPFLAGS being passed to CONFIGURE_ENV and MAKE_ENV
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 14 12:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Gerald Pfeifer
>Release:
>Organization:
>Environment:
>Description:
Recently a change of mine to pass CPPFLAGS to CONFIGURE_ENV
and MAKE_ENV has been applied to Mk/bsd.port.mk.
In consequence, individual ports no long should pass this to
either explicitly, that is, it would be great could portlint
warn about the like of
CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}"
and
MAKE_ENV= CPPFLAGS="${CPPFLAGS}"
In fact, not just the forms about, but any setting of
CPPFLAGS in these two, also along the lines of
CONFIGURE_ENV= CPPFLAGS="${SOMETHING_ELSE}"
or
MAKE_ENV= CPPFLAGS="-Dfoo -D bar"
should be warned about since, really, CPPFLAGS should be
set in the port Makefile and the rest should "just happen".
A regular expression could like something like
^(CONFIGURE_ENV|MAKE_ENV)(=|?=|+=).*CPPFLAGS
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103141205.p2EC5RBA066687>