Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Nov 2021 00:02:51 GMT
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 64c69419a96c - stable/13 - arm64/gicv3: improve a panic message
Message-ID:  <202111190002.1AJ02pMZ072781@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=64c69419a96c03a17c2efc8816fe3e332edacded

commit 64c69419a96c03a17c2efc8816fe3e332edacded
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2021-11-09 22:11:15 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2021-11-19 00:01:27 +0000

    arm64/gicv3: improve a panic message
    
    Print the device/unit in the panic message for which we cannot get
    the MSI device ID to have a clue where to start looking.
    While here use __func__ instead of hardcoding the function name.
    
    (cherry picked from commit fad51d34f21359c5b94ca94842381c3e000f475e)
---
 sys/arm64/arm64/gicv3_its.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/arm64/arm64/gicv3_its.c b/sys/arm64/arm64/gicv3_its.c
index 9c058dbe7f99..84b1a574f02f 100644
--- a/sys/arm64/arm64/gicv3_its.c
+++ b/sys/arm64/arm64/gicv3_its.c
@@ -1110,7 +1110,8 @@ its_get_devid(device_t pci_dev)
 	uintptr_t id;
 
 	if (pci_get_id(pci_dev, PCI_ID_MSI, &id) != 0)
-		panic("its_get_devid: Unable to get the MSI DeviceID");
+		panic("%s: %s: Unable to get the MSI DeviceID", __func__,
+		    device_get_nameunit(pci_dev));
 
 	return (id);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202111190002.1AJ02pMZ072781>