Date: Fri, 21 Jun 2019 14:54:05 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Christoph Moench-Tegeder <cmt@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504800 - in head/cad: . kicad-doc Message-ID: <20190621145405.GA390@FreeBSD.org> In-Reply-To: <201906211352.x5LDq1E6071357@repo.freebsd.org> References: <201906211352.x5LDq1E6071357@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 21, 2019 at 01:52:01PM +0000, Christoph Moench-Tegeder wrote: > New Revision: 504800 > URL: https://svnweb.freebsd.org/changeset/ports/504800 > > Log: > cad/kicad-doc: online help files and documentation for cad/kicad Sorry, but I'm afraid it was badly reviewed. > +MAINTAINER= cmt@FreeBSD.org > +COMMENT= KiCad Online Documentation/Help Files Comment is confusing ("online" typically means one does not have to install anything locally, that makes it "offline")... > +++ head/cad/kicad-doc/pkg-descr Fri Jun 21 13:52:01 2019 > @@ -0,0 +1,3 @@ > +This port installs the official KiCad schematic symbol libraries. ... and does not align well with the port description. The latter is also expected to be more elaborate. Your current pkg-descr is what the COMMENT line should be. > +PLIST_SUB= PORTDOCS="" Why not simply remove %%PORTDOCS%% from the pkg-plist if you're setting it to an empty value unconditionally? > +NO_ARCH= yes This knob should appear earlier. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190621145405.GA390>