Date: Tue, 4 Jan 2011 10:27:47 +0100 From: "Pietro Cerutti" <gahr@gahr.ch> To: Stanislav Sedov <stas@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/freeimage Makefile distinfo pkg-descr ports/graphics/freeimage/files patch-Source-LibOpenJPEG_opj_malloc.h Message-ID: <20110104092747.GJ72669@gahrfit.gahr.ch> In-Reply-To: <20101230161846.16ad0b3c.stas@FreeBSD.org> References: <201012200900.oBK90cfc062324@repoman.freebsd.org> <20101220103733.GA6738@FreeBSD.org> <20101220110727.GT7557@gahrfit.gahr.ch> <20101230161846.16ad0b3c.stas@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2010-Dec-30, 16:18, Stanislav Sedov wrote: > On Mon, 20 Dec 2010 12:07:27 +0100 > "Pietro Cerutti" <gahr@gahr.ch> mentioned: > > > > > 1) I don't think anybody is interested in this pkg-descr change: you > > have done a minor rephrasing but haven't minimally changed the sense. > > I don't want to start a flame war, but why did you committed it then? > Everything changed deserves at least a small note in the commit log. Well I tend to disagree here. I see a commit message as a way to convey important notes about a commit. The files touched by a commit are listed, and the repository is there for anybody to see, if one is interested in the details. Let's not bury an important key note beneath a mountain of details. I would like to avoid to have to write a line like this - add a patch file to fix an include line that used the deprecated header alloc.h instead of stdlib.h for a patch file like this - #include <alloc.h> + #include <stdlib.h> Let's please keep things slim and functional :) -- Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0i6AwACgkQwMJqmJVx944hbQCeNFpMbcqCLJQ+mhv8OpsPEca7 VLoAoKkmseC6MfcxMntxJu8+Ky7eTqJ1 =YGGu -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110104092747.GJ72669>