Date: Wed, 08 Jan 2020 05:34:04 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 243164] blacklistd not handling masks correctly Message-ID: <bug-243164-227-RVLSThDRKo@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-243164-227@https.bugs.freebsd.org/bugzilla/> References: <bug-243164-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164 --- Comment #7 from Conrad Meyer <cem@freebsd.org> --- (In reply to Helge Oldach from comment #6) Thanks for testing it out. > So it's not a documentation error as I was thinking but indeed a bug. Yep. Nice find! > What I still don't understand however is why the netmask can be FSTAR at all? > What is the point? I can't follow the semantics. Why would we want to compare an > incoming IP address (with implied /32 mask) to a template with an "unknown" > netmask? I suspect a proper fix might involve setting it to 32 (or 128 in the > IPv6 case) right away if no mask is specified? I completely agree. I'm also not exactly in love with the custom file format (with ad-hoc C parser and no formal grammar) and suggested just using UCL or JSON to Kurt a few years ago, but he was opposed at the time. (IIRC he had indicated plans to use a formal grammar for the existing format, at least, but never got to it.) -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243164-227-RVLSThDRKo>