Date: Mon, 16 Oct 2017 20:08:19 +0300 From: Toomas Soome <tsoome@me.com> To: Andrew Turner <andrew@fubar.geek.nz> Cc: Warner Losh <imp@bsdimp.com>, eric@meatspace.com, src-committers <src-committers@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader Message-ID: <CB1D0E5E-10B3-46E1-A222-B85134876C69@me.com> In-Reply-To: <3BED6A0F-689C-4B89-A2AA-6990FB473539@fubar.geek.nz> References: <201710160359.v9G3xCCi087576@repo.freebsd.org> <C5C51AA5-F439-4B38-8FCF-0AA3C1FF7E34@fubar.geek.nz> <CANCZdfptCfDS=NrCrjZt03jkuoTZzfyvTa3VjWuVoT1074QZAg@mail.gmail.com> <C58ADF11-C9AC-405C-880B-BBC864DB5EC3@fubar.geek.nz> <CANCZdfpQ36yB=n0CnS3pcwLMAT=h-gCnMh-=GPU0KwG-e6L2QA@mail.gmail.com> <3BED6A0F-689C-4B89-A2AA-6990FB473539@fubar.geek.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
The arm (uboot) has a bit different approach on block device(s), see = efipart_hdinfo_add_filepath() in efipart.c; the code needs to check for = MEDIA_FILEPATH_DP, I think. rgds, toomas > On 16 Oct 2017, at 19:07, Andrew Turner <andrew@fubar.geek.nz> wrote: >=20 > Correct, it is aarch64. It runs a similar qemu command, however I also = see it under the ARM Foundation model so it seems to not be simulator = specific. >=20 > Andrew >=20 >> On 16 Oct 2017, at 16:56, Warner Losh <imp@bsdimp.com = <mailto:imp@bsdimp.com>> wrote: >>=20 >> So this is on aarch64? Is this running a standardish qemu setup as = documented on https://wiki.freebsd.org/arm64/QEMU = <https://wiki.freebsd.org/arm64/QEMU>; ? Or are there tricks that we need = to cope with... >>=20 >> If we can't get good resoltuion on this today, I plan on backing out = the entire change. >>=20 >> Warner >>=20 >> On Mon, Oct 16, 2017 at 9:38 AM, Andrew Turner <andrew@fubar.geek.nz = <mailto:andrew@fubar.geek.nz>> wrote: >> I have a local Jenkins setup that builds images & tries to run under = various simulators. The final image is built with mkimg. I=E2=80=99m = running it under qemu. >>=20 >> Andrew >>=20 >>> On 16 Oct 2017, at 13:19, Warner Losh <imp@bsdimp.com = <mailto:imp@bsdimp.com>> wrote: >>>=20 >>> I'll take a look, but I've also ccd Eric so he can figure out what = went wrong with is code in your environment. What env is That? >>>=20 >>> Warnee >>>=20 >>> On Oct 16, 2017 3:26 AM, "Andrew Turner" <andrew@fubar.geek.nz = <mailto:andrew@fubar.geek.nz>> wrote: >>>=20 >>> > On 16 Oct 2017, at 04:59, Warner Losh <imp@FreeBSD.org = <mailto:imp@FreeBSD.org>> wrote: >>> > >>> > Author: imp >>> > Date: Mon Oct 16 03:59:11 2017 >>> > New Revision: 324646 >>> > URL: https://svnweb.freebsd.org/changeset/base/324646 = <https://svnweb.freebsd.org/changeset/base/324646>; >>> > >>> > Log: >>> > Unify boot1 with loader >>> > >>> > Refactor boot1 to use the same I/O code as /boot/loader uses. = Refactor >>> > to use the common efi_main.c. >>> > >>> > Submitted by: Eric McCorkle >>> > Differential Revision: https://reviews.freebsd.org/D10447 = <https://reviews.freebsd.org/D10447>; >>> > >>> > Added: >>> > head/sys/boot/efi/libefi/efi_main.c (contents, props changed) >>> > - copied, changed from r324645, = head/sys/boot/efi/loader/efi_main.c >>> > Deleted: >>> > head/sys/boot/efi/boot1/boot_module.h >>> > head/sys/boot/efi/boot1/ufs_module.c >>> > head/sys/boot/efi/boot1/zfs_module.c >>> > head/sys/boot/efi/loader/efi_main.c >>> > Modified: >>> > head/sys/boot/efi/boot1/Makefile >>> > head/sys/boot/efi/boot1/boot1.c >>> > head/sys/boot/efi/libefi/Makefile >>> > head/sys/boot/efi/loader/Makefile >>>=20 >>> Hello Warner, >>>=20 >>> After this change I=E2=80=99m getting the following panic on various = test VMs. >>>=20 >>> Andrew >>>=20 >>> >> FreeBSD EFI boot block >>>=20 >>> Loader path: /boot/loader.efi >>>=20 >>> Load Path: \EFI\BOOT\BOOTAA64.EFI >>> Load Device: = VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003C000A00000000)/HD(1,GPT,DD40= E9C6-B247-11E7-AA0A-15EFE1BBB7CF,0x3,0x640) >>> panic: Couldn't trim device path >>> --> Press a key on the console to reboot <-- >>>=20 >>=20 >>=20 >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CB1D0E5E-10B3-46E1-A222-B85134876C69>