Date: Sat, 29 Apr 2017 04:41:36 +0000 From: "anish (Anish Gupta)" <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D10540: vmx: explicit checking for necessary invvpid/invept types Message-ID: <ea75fa9de60b94cc78ffddc26f8610cc@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-dvcgq67pzsk2bfph2tq5-req@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
anish added inline comments. INLINE COMMENTS > ept.c:58-59 > +#define INVVPID_REQUIRED_TYPES_MASK \ > + ((1UL << (INVVPID_TYPE_SINGLE_CONTEXT + 40)) | \ > + (1UL << (INVVPID_TYPE_ALL_CONTEXTS + 40))) > +#define INVVPID_REQUIRED_TYPES_SUPPORTED(cap) \ This is cryptic, better to have separate macros for it #define INVVPID_SINGLE_CTX_SUP(cap) ((cap) & (1UL << 41)) #define INVVPID_ALL_CTX_SUP(cap) ((cap) & (1UL << 42)) REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D10540 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: jan.dakinevich_gmail.com, grehan, neel Cc: anish, imp, freebsd-virtualization-listhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ea75fa9de60b94cc78ffddc26f8610cc>