Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 28 Jan 2015 18:13:53 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r277840 - in projects/clang360-import/contrib/openpam: . lib/libpam modules/pam_unix
Message-ID:  <201501281813.t0SIDrdF072526@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: dim
Date: Wed Jan 28 18:13:52 2015
New Revision: 277840
URL: https://svnweb.freebsd.org/changeset/base/277840

Log:
  Apply changeset 854 from upstream openpam (by Dag-Erling Smørgrav):
  
    Silence all remaining qual-cast warnings except in the test suite.

Modified:
  projects/clang360-import/contrib/openpam/CREDITS
  projects/clang360-import/contrib/openpam/configure.ac
  projects/clang360-import/contrib/openpam/lib/libpam/openpam_dispatch.c
  projects/clang360-import/contrib/openpam/modules/pam_unix/pam_unix.c

Modified: projects/clang360-import/contrib/openpam/CREDITS
==============================================================================
--- projects/clang360-import/contrib/openpam/CREDITS	Wed Jan 28 18:13:16 2015	(r277839)
+++ projects/clang360-import/contrib/openpam/CREDITS	Wed Jan 28 18:13:52 2015	(r277840)
@@ -21,6 +21,7 @@ ideas:
 	Christos Zoulas <christos@netbsd.org>
 	Daniel Richard G. <skunk@iskunk.org>
 	Darren J. Moffat <darren.moffat@sun.com>
+	Dimitry Andric <dim@freebsd.org>
 	Dmitry V. Levin <ldv@altlinux.org>
 	Don Lewis <truckman@freebsd.org>
 	Emmanuel Dreyfus <manu@netbsd.org>

Modified: projects/clang360-import/contrib/openpam/configure.ac
==============================================================================
--- projects/clang360-import/contrib/openpam/configure.ac	Wed Jan 28 18:13:16 2015	(r277839)
+++ projects/clang360-import/contrib/openpam/configure.ac	Wed Jan 28 18:13:52 2015	(r277840)
@@ -110,7 +110,7 @@ AC_SUBST(CRYPTO_LIBS)
 
 AC_ARG_ENABLE([developer-warnings],
     AS_HELP_STRING([--enable-developer-warnings], [enable strict warnings (default is NO)]),
-    [CFLAGS="${CFLAGS} -Wall -Wextra"])
+    [CFLAGS="${CFLAGS} -Wall -Wextra -Wcast-qual"])
 AC_ARG_ENABLE([debugging-symbols],
     AS_HELP_STRING([--enable-debugging-symbols], [enable debugging symbols (default is NO)]),
     [CFLAGS="${CFLAGS} -O0 -g -fno-inline"])

Modified: projects/clang360-import/contrib/openpam/lib/libpam/openpam_dispatch.c
==============================================================================
--- projects/clang360-import/contrib/openpam/lib/libpam/openpam_dispatch.c	Wed Jan 28 18:13:16 2015	(r277839)
+++ projects/clang360-import/contrib/openpam/lib/libpam/openpam_dispatch.c	Wed Jan 28 18:13:52 2015	(r277840)
@@ -117,7 +117,7 @@ openpam_dispatch(pam_handle_t *pamh,
 			openpam_log(PAM_LOG_LIBDEBUG, "calling %s() in %s",
 			    pam_sm_func_name[primitive], chain->module->path);
 			r = (chain->module->func[primitive])(pamh, flags,
-			    chain->optc, (const char **)chain->optv);
+			    chain->optc, (const char **)(intptr_t)chain->optv);
 			pamh->current = NULL;
 			openpam_log(PAM_LOG_LIBDEBUG, "%s: %s(): %s",
 			    chain->module->path, pam_sm_func_name[primitive],

Modified: projects/clang360-import/contrib/openpam/modules/pam_unix/pam_unix.c
==============================================================================
--- projects/clang360-import/contrib/openpam/modules/pam_unix/pam_unix.c	Wed Jan 28 18:13:16 2015	(r277839)
+++ projects/clang360-import/contrib/openpam/modules/pam_unix/pam_unix.c	Wed Jan 28 18:13:52 2015	(r277840)
@@ -74,7 +74,7 @@ pam_sm_authenticate(pam_handle_t *pamh, 
 #endif
 	struct passwd *pwd;
 	const char *user;
-	char *crypt_password, *password;
+	const char *crypt_password, *password;
 	int pam_err, retry;
 
 	(void)argc;
@@ -98,7 +98,7 @@ pam_sm_authenticate(pam_handle_t *pamh, 
 	for (retry = 0; retry < 3; ++retry) {
 #ifdef OPENPAM
 		pam_err = pam_get_authtok(pamh, PAM_AUTHTOK,
-		    (const char **)&password, NULL);
+		    &password, NULL);
 #else
 		resp = NULL;
 		pam_err = (*conv->conv)(1, &msgp, &resp, conv->appdata_ptr);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201501281813.t0SIDrdF072526>