Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 May 2025 22:40:05 -0400
From:      Justin Hibbits <chmeee@has.gonegalt.net>
To:        Justin Hibbits <jhibbits@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: c4921a0faaf1 - main - powerpc: Always use BE tag in nexus_map_resource
Message-ID:  <6408B2A6-43EA-4F43-B33D-537631D081A0@has.gonegalt.net>
In-Reply-To: <202505130228.54D2Sxfb009535@gitrepo.freebsd.org>
References:  <202505130228.54D2Sxfb009535@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


> On May 12, 2025, at 22:28, Justin Hibbits <jhibbits@freebsd.org> =
wrote:
>=20
> The branch main has been updated by jhibbits:
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3Dc4921a0faaf1683f39347dd066000d92=
9c39c8b9
>=20
> commit c4921a0faaf1683f39347dd066000d929c39c8b9
> Author:     Justin Hibbits <jhibbits@FreeBSD.org>
> AuthorDate: 2025-05-13 01:35:14 +0000
> Commit:     Justin Hibbits <jhibbits@FreeBSD.org>
> CommitDate: 2025-05-13 01:35:14 +0000
>=20
>    powerpc: Always use BE tag in nexus_map_resource
>=20
>    7b5a5e4e replaced nexus_activate_resource() with the bus generic
>    equivalent, which uses bus_map_resource().  However, though not =
intended
>    to have a functional change, nexus_map_resource() uses the bus tag =
of
>    the build (BE vs LE), while nexus_activate_resource() always =
explicitly
>    set a big-endian tag, leading to failures on powerpc64le now.  =
Using BE
>    unless otherwise explicitly specified with the RF_LITTLEENDIAN =
fixes LE
>    on bare metal, and doesn't hurt in a VM, which nexus_map_resource() =
was
>    added for.
>=20
>    Reported by:    pkubaj
>    Tested by:      pkubaj
>    Fixes:          7b5a5e4e("powerpc nexus: Use bus_generic_rman_*")
>    MFC after:      1 day

Short MFC window so it can get into 14.3.

- Justin=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6408B2A6-43EA-4F43-B33D-537631D081A0>