Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 03 Jan 2020 20:02:24 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 243064] mount_unionfs panics in latest -current
Message-ID:  <bug-243064-227-bAq7aJtGBD@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-243064-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-243064-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243064

--- Comment #4 from Mason Loring Bliss <mason@blisses.org> ---
The amazing folks in Freenode #freebsd have nailed it down:

14:47 < RhodiumToad> everywhere else, VOP_UNLOCK is called as VOP_UNLOCK(vp=
,0)
14:48 < RhodiumToad> unionfs uses VOP_UNLOCK(vp,LK_RELEASE), which I suspec=
t is=20
                     just an obsolete form from years back
...
14:51 < RhodiumToad> anyway, unionfs can probably be fixed trivially
14:52 < kevans91> yeah, looks like it just has a dozen or so VOP_UNLOCK=20
                  invocations that are incorrect

related:

14:50 < kevans91> I thought mjg was cooking up something to drop the second=
=20
                  argument entirely
14:50 < kevans91> ah, yeah: - Exp-run PR 240156 to remove flags argument fr=
om=20
                  VOP_UNLOCK
14:50 < VimDiesel> 240156 =E2=80=93 Remove flags argument from VOP_UNLOCK=20
                   https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D2401=
56
14:51 < kevans91> https://reviews.freebsd.org/D21427
14:51 < VimDiesel> Title: =E2=9A=99 D21427 vfs: remove flags argument from =
VOP_UNLOCK=20
                   (at reviews.freebsd.org)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243064-227-bAq7aJtGBD>