Date: Fri, 08 Jul 2005 15:24:34 -0600 From: Scott Long <scottl@samsco.org> To: Maxim Sobolev <sobomax@portaone.com> Cc: Roman Kurakin <rik@FreeBSD.org>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c Message-ID: <42CEEF12.4070904@samsco.org> In-Reply-To: <42CECCD8.5070201@portaone.com> References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com>
index | next in thread | previous in thread | raw e-mail
Maxim Sobolev wrote: > Roman Kurakin wrote: > >> rik 2005-07-08 18:36:59 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/compat/ndis subr_ntoskrnl.c Log: >> Use implicit type cast for ->k_lock to fix compilation of ndis >> as a part of the GENERIC kernel with INVARIANT* and WITNESS* >> turned off. > > > I think the better fix is to change type of k_lock member from void* to > the struct mtx*, I've already commited such change to the RELENG_5 few > days ago. > > -Maxim It's a void* for portability with other OS's. This work has already been ported to Solaris, and maybe even other OS's by now. Reducing the portability is a bad idea, and will likely get you smacked around by Bill when he notices. I'd highly recommend not doing this again in the future. Scotthome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42CEEF12.4070904>