Date: Tue, 4 Oct 2016 18:04:46 +0000 (UTC) From: Mateusz Guzik <mjg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r306682 - stable/11/sys/fs/nullfs Message-ID: <201610041804.u94I4khd086370@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mjg Date: Tue Oct 4 18:04:46 2016 New Revision: 306682 URL: https://svnweb.freebsd.org/changeset/base/306682 Log: MFC r305659: nullfs: plug vnode ref leak in null_vptocnp The lower vnode is already referenced and nodeget is supposed to consume the reference. Thus the extra vref call was causing a leak. Modified: stable/11/sys/fs/nullfs/null_vnops.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/fs/nullfs/null_vnops.c ============================================================================== --- stable/11/sys/fs/nullfs/null_vnops.c Tue Oct 4 17:57:30 2016 (r306681) +++ stable/11/sys/fs/nullfs/null_vnops.c Tue Oct 4 18:04:46 2016 (r306682) @@ -896,7 +896,6 @@ null_vptocnp(struct vop_vptocnp_args *ap vn_lock(vp, locked | LK_RETRY); return (ENOENT); } - vref(ldvp); error = null_nodeget(vp->v_mount, ldvp, dvp); if (error == 0) { #ifdef DIAGNOSTIC
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201610041804.u94I4khd086370>