Date: Mon, 23 Oct 2000 01:48:26 +0900 From: "Akinori MUSHA" <knu@idaemons.org> To: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> Cc: freebsd-stable@FreeBSD.ORG, freebsd-ports@FreeBSD.ORG, asami@FreeBSD.ORG Subject: Re: Supporting INCS on 3-STABLE Message-ID: <864s24styd.wl@archon.local.idaemons.org> In-Reply-To: <200010221553.IAA33410@gndrsh.dnsmgr.net> References: <86puktyihz.wl@archon.local.idaemons.org> <200010221553.IAA33410@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
At Sun, 22 Oct 2000 08:53:07 -0700 (PDT),
Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
> > I was noticed that my textproc/expat port doesn't install header files
> > automatically on 3-STABLE because 3-STABLE's bsd.lib.mk doesn't
> > recognize INCS macro.
>
> Your textproc/expat port is abusing an interface that is not public,
> please remove the dependency of INCS from your port.
While src/lib/*/Makefile are all using it on 4-STABLE and 5-CURRENT?
Why didn't it go public? The facility that _is_ fully used should be
documented as soon as possible, IMO.
> > Now, can we merge the INCS support to 3-STABLE? I'm not saying that
> > we should modify src/lib/*/Makefile so they use INCS macro, but just
> > make bsd.lib.mk support the macro and leave src/lib/*/Makefile for
> > safety.
>
> No, please don't. It was bad enough that someone took expermintal
> work from -current into 4-STABLE directly against the authors recomendations.
You know that was simply a mistake. Please take a look at the history
of src/lib/libcom_err/Makefile. We should remove INCS because it's
not actually used. In fact, assar forgot to back out the addition of
INCS. (1.8.2.1 -> 1.8.2.2 -> 1.8.2.3)
> > I found only one file defines INCS though the variable is not actually
> > used, and we can remove the definition.
>
> Are you sure it is not used?
Yes, on 3-STABLE.
> What happens during a make install in
> src/lib/libcom_err? Don't com_err.h and com_right.h get installed
> by the backcall to _includeinstall:?
No. They are installed by the "beforeinstall" target defined in
src/lib/libcom_err/Makefile. Again, the definition of INCS is
redundant and thus should be removed.
> > If no one opposes and the merging is done, I hope bsd.lib.mk will be
> > included in the ports upgrade kits for 3.x.
>
> I oppose the addition of _includeinstall: into the 3.x tree.
Okay, let me reconsider it.
--
/
/__ __
/ ) ) ) ) / and.or.jp / ruby-lang.org
Akinori -Aki- MUSHA aka / (_ / ( (__( @ idaemons.org / FreeBSD.org
"We're only at home when we're on the run, on the wing, on the fly"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864s24styd.wl>