Date: Thu, 27 Nov 2014 09:18:26 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Hans Petter Selasky <hps@selasky.org>, Michael Tuexen <tuexen@freebsd.org> Cc: Lawrence Stewart <lstewart@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Luigi Rizzo <rizzo@iet.unipi.it>, "K. Macy" <kmacy@freebsd.org>, Navdeep Parhar <np@freebsd.org> Subject: Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues] Message-ID: <CAJ-Vmo=VG6_og-nYYwLkfHh-DOZQf6NM=aUzaBGY890vCAqTVg@mail.gmail.com> In-Reply-To: <CAJ-Vmo=qc255RsqQB7UJv%2Bo7CzNGG_Mfny_XRk2=jJaUwwSu8g@mail.gmail.com> References: <546CE948.2070105@selasky.org> <CAHM0Q_NwfjH-XqwTaRiZdntAiT=73-dETogQRWeyhEZQm-Ky2Q@mail.gmail.com> <546D0CE3.602@selasky.org> <54775B0E.3000004@selasky.org> <CAJ-Vmo=qc255RsqQB7UJv%2Bo7CzNGG_Mfny_XRk2=jJaUwwSu8g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Erk - SCTP folk - are you using the mbuf flowid field for something SCTP specific? -adrian On 27 November 2014 at 09:13, Adrian Chadd <adrian@freebsd.org> wrote: > Hi, > > I need a little more time to review this. Sorry :( > > > > -a > > > On 27 November 2014 at 09:10, Hans Petter Selasky <hps@selasky.org> wrote: >> On 11/19/14 22:34, Hans Petter Selasky wrote: >>> >>> On 11/19/14 21:46, K. Macy wrote: >>>> >>>> Hi Hans, >>>> >>>> It mostly looks fine, but it's a large change and there are some >>>> places in the patch where it isn't clear that the right thing is being >>>> done by looking at the patch alone. Please give us some time to >>>> review. >>>> >>> >>> No problem. Do you think you need more than a week? >>> >>> --HPS >>> >> >> Hi, >> >> Do you need more time to review my patch? >> >> Any issues that should be fixed? >> >> --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=VG6_og-nYYwLkfHh-DOZQf6NM=aUzaBGY890vCAqTVg>