Date: Thu, 18 Feb 2016 08:45:02 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 189284] dd(1): may write junk if conv=sparse with obs < ibs Message-ID: <bug-189284-8-FbVirL4zcT@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-189284-8@https.bugs.freebsd.org/bugzilla/> References: <bug-189284-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=189284 --- Comment #5 from commit-hook@freebsd.org --- A commit references this bug: Author: thomas Date: Thu Feb 18 08:44:17 UTC 2016 New revision: 295749 URL: https://svnweb.freebsd.org/changeset/base/295749 Log: Reorganize the handling all-zeroes terminal block in sparse mode The intent of the previous code in that case was to force an explicit write, but the implementation was incorrect, and as a result the write was never performed. This new implementation instead uses ftruncate(2) to extend the file with a trailing hole. Also introduce regression tests for these cases. PR: 189284 (original PR whose fix introduced this bug) PR: 207092 Differential Revision: D5248 Reviewed by: sobomax,kib MFC after: 2 weeks Changes: head/bin/dd/Makefile head/bin/dd/dd.c head/bin/dd/dd.h head/bin/dd/gen.c head/bin/dd/ref.obs_zeroes -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-189284-8-FbVirL4zcT>