Date: Tue, 23 Apr 2013 10:35:45 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: perl@freebsd.org Subject: [patch] net/p5-RPC-XML loop detection bug Message-ID: <86txmxskym.fsf@ds4.des.no>
next in thread | raw e-mail | index | archive | help
The hash serializing code in RPC::XML tries to detect and prevent loops,
but what it actually does is detect and prevent repetitions. The
easiest way to reproduce this is to try to serialize a hash containing
two DateTime objects representing the same time, because DateTime
objects are singletons.
I've submitted a patch upstream and received a positive response, but it
hasn't appeared on github and there is no sign of a new release. I'd
like to commit the following patch to net/p5-RPC-XML:
Index: net/p5-RPC-XML/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- net/p5-RPC-XML/Makefile (revision 316245)
+++ net/p5-RPC-XML/Makefile (working copy)
@@ -7,6 +7,7 @@
=20
PORTNAME=3D RPC-XML
PORTVERSION=3D 0.77
+PORTREVISION=3D 1
CATEGORIES=3D net www perl5
MASTER_SITES=3D CPAN
PKGNAMEPREFIX=3D p5-
Index: net/p5-RPC-XML/files/patch-lib-RPC-XML.pm
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- net/p5-RPC-XML/files/patch-lib-RPC-XML.pm (revision 0)
+++ net/p5-RPC-XML/files/patch-lib-RPC-XML.pm (working copy)
@@ -0,0 +1,10 @@
+--- lib/RPC/XML.pm.orig 2011-08-22 11:29:30.000000000 +0200
++++ lib/RPC/XML.pm 2013-04-23 10:28:19.780990362 +0200
+@@ -258,6 +258,7 @@
+ $type =3D reftype $_;
+ die "Un-convertable reference: $type, cannot use\n";
+ }
++ $seenrefs->{$_}--;
+ }
+ # You have to check ints first, because they match the
+ # next pattern (for doubles) too
Property changes on: net/p5-RPC-XML/files/patch-lib-RPC-XML.pm
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86txmxskym.fsf>