Date: Mon, 3 Sep 2001 13:33:28 +0200 From: Anton Berezin <tobez@tobez.org> To: Josef Karthauser <joe@tao.org.uk> Cc: Paul Richards <paul@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/update pkg_update.pl Message-ID: <20010903133328.A35211@heechee.tobez.org> In-Reply-To: <20010902012740.A11122@tao.org.uk>; from joe@tao.org.uk on Sun, Sep 02, 2001 at 01:27:40AM %2B0100 References: <200012300014.eBU0E1238805@freefall.freebsd.org> <20010902012740.A11122@tao.org.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 02, 2001 at 01:27:40AM +0100, Josef Karthauser wrote: > On Fri, Dec 29, 2000 at 04:14:01PM -0800, Paul Richards wrote: > > paul 2000/12/29 16:14:01 PST > > > > Modified files: > > usr.sbin/pkg_install/update pkg_update.pl > > Log: > > Change open modes from ">$file" to "> $file" because it's much safer should > > $file not be what you expect, particularly should $file turn out to be > > "+REQUIRES" since ">+" is a valid open mode. > > > > This isn't currently a problem since $file is constructed safely > > but it removes the potential of future problems. > > Pointed out by Anton Berezin. > > > > Revision Changes Path > > 1.3 +3 -3 src/usr.sbin/pkg_install/update/pkg_update.pl > > Sorry I've taken so long to get around to this one. > > Are you sure? The perl docs for 'open' explicitly say that the + > needs to come before the >. Oops. It looks like it was not a problem. ;-) I think that this change should stay regardless, however. "> $file" is easier to read than ">$file". +Anton. -- May the tuna salad be with you. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010903133328.A35211>