Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Jun 2017 16:44:39 +0000 (UTC)
From:      "Stephen J. Kiernan" <stevek@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r319443 - head/lib/libutil
Message-ID:  <201706011644.v51GidaT029411@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: stevek
Date: Thu Jun  1 16:44:39 2017
New Revision: 319443
URL: https://svnweb.freebsd.org/changeset/base/319443

Log:
  When sysctlbyname fails, free buf before returning.
  
  Submitted by:	Thomas Rix <trix@juniper.net>
  Reviewed by:	jhb
  Approved by:	sjg (mentor)
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D9867

Modified:
  head/lib/libutil/kinfo_getvmobject.c

Modified: head/lib/libutil/kinfo_getvmobject.c
==============================================================================
--- head/lib/libutil/kinfo_getvmobject.c	Thu Jun  1 16:03:01 2017	(r319442)
+++ head/lib/libutil/kinfo_getvmobject.c	Thu Jun  1 16:44:39 2017	(r319443)
@@ -46,8 +46,10 @@ kinfo_getvmobject(int *cntp)
 
 	buf = NULL;
 	for (i = 0; i < 3; i++) {
-		if (sysctlbyname("vm.objects", NULL, &len, NULL, 0) < 0)
+		if (sysctlbyname("vm.objects", NULL, &len, NULL, 0) < 0) {
+			free(buf);
 			return (NULL);
+		}
 		buf = reallocf(buf, len);
 		if (buf == NULL)
 			return (NULL);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201706011644.v51GidaT029411>