Date: Tue, 8 Oct 2024 10:32:57 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 57dc9c86c152 - main - devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to 1.16.0" Message-ID: <CAFDf7UJhvr0DqgSAp52NpddT7WMDFP9zSD4LmXjyLKyrUEioMg@mail.gmail.com> In-Reply-To: <202410080924.4989O2DW090082@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] We will need to ask upstream to fix OpenMP detection on FreeBSD like macports did: https://github.com/Rdatatable/data.table/issues/6409 A quick fix is: ``` --- configure.orig 2024-10-08 08:42:43 UTC +++ configure @@ -144,7 +144,17 @@ detect_openmp () { fi # uname=Darwin - # No support for OpenMP available + + if [ "$(uname)" = "FreeBSD" ]; then + + export PKG_CFLAGS="${PKG_CFLAGS}" + export PKG_LIBS="${PKG_LIBS}" + export R_OPENMP_ENABLED=1 + return + + fi # uname=FreeBSD + + # No support for OpenMP available export R_OPENMP_ENABLED=0 } ``` But I don't have enough skills to evaluate the correct FreeBSD support. Thanks Nuno Teixeira <eduardo@freebsd.org> escreveu (terça, 8/10/2024 à(s) 10:24): > The branch main has been updated by eduardo: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=57dc9c86c152a5abc0a367d49cbf265a18b738d8 > > commit 57dc9c86c152a5abc0a367d49cbf265a18b738d8 > Author: Nuno Teixeira <eduardo@FreeBSD.org> > AuthorDate: 2024-10-08 09:16:24 +0000 > Commit: Nuno Teixeira <eduardo@FreeBSD.org> > CommitDate: 2024-10-08 09:23:19 +0000 > > devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to > 1.16.0" > > OpenMP detection broken. > > See also: > https://github.com/Rdatatable/data.table/issues/6559 > > https://github.com/Rdatatable/data.table/commit/096b20f1f1b9788787a826ba3d32177ed9836352 > > This reverts commit 5f823f135151a2a77b54ef0533c4c932e41ca771. > --- > devel/R-cran-data.table/Makefile | 4 +--- > devel/R-cran-data.table/distinfo | 6 +++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/devel/R-cran-data.table/Makefile > b/devel/R-cran-data.table/Makefile > index 34a8aa0ea207..100dbe683927 100644 > --- a/devel/R-cran-data.table/Makefile > +++ b/devel/R-cran-data.table/Makefile > @@ -1,5 +1,5 @@ > PORTNAME= data.table > -DISTVERSION= 1.16.0 > +DISTVERSION= 1.15.4 > CATEGORIES= devel > DISTNAME= ${PORTNAME}_${DISTVERSION} > > @@ -12,8 +12,6 @@ LICENSE_FILE= ${WRKSRC}/LICENSE > > USES= cran:auto-plist,compiles pkgconfig > > -TESTING_UNSAFE= > https://github.com/Rdatatable/data.table/issues/6559 > - > NO_ARCH_IGNORE= data_table.so > > OPTIONS_DEFINE= OPENMP > diff --git a/devel/R-cran-data.table/distinfo > b/devel/R-cran-data.table/distinfo > index dfc347728df6..497612d9aa61 100644 > --- a/devel/R-cran-data.table/distinfo > +++ b/devel/R-cran-data.table/distinfo > @@ -1,3 +1,3 @@ > -TIMESTAMP = 1728300398 > -SHA256 (data.table_1.16.0.tar.gz) = > 58f8aec50099de80d84faa50295c17295d465f669be79b46c3c7ca18c56ef9cd > -SIZE (data.table_1.16.0.tar.gz) = 5302544 > +TIMESTAMP = 1711960872 > +SHA256 (data.table_1.15.4.tar.gz) = > ab8065ff946d59ecaaf5eaf91a975495c07c30caad97a71205c72e41a740cb53 > +SIZE (data.table_1.15.4.tar.gz) = 5387593 > -- Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org [-- Attachment #2 --] <div dir="ltr"><div>We will need to ask upstream to fix OpenMP detection on FreeBSD like macports did:</div><div><br></div><div><a href="https://github.com/Rdatatable/data.table/issues/6409">https://github.com/Rdatatable/data.table/issues/6409</a></div><div><br></div><div>A quick fix is:<br><br>```</div><div>--- configure.orig 2024-10-08 08:42:43 UTC<br>+++ configure<br>@@ -144,7 +144,17 @@ detect_openmp () {<br><br> fi # uname=Darwin<br><br>- # No support for OpenMP available<br>+<br>+ if [ "$(uname)" = "FreeBSD" ]; then<br>+<br>+ export PKG_CFLAGS="${PKG_CFLAGS}"<br>+ export PKG_LIBS="${PKG_LIBS}"<br>+ export R_OPENMP_ENABLED=1<br>+ return<br>+<br>+ fi # uname=FreeBSD<br>+<br>+ # No support for OpenMP available<br> export R_OPENMP_ENABLED=0<br> }</div><div>```<br><br></div><div>But I don't have enough skills to evaluate the correct FreeBSD support.<br><br></div><div>Thanks<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Nuno Teixeira <<a href="mailto:eduardo@freebsd.org">eduardo@freebsd.org</a>> escreveu (terça, 8/10/2024 à(s) 10:24):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by eduardo:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=57dc9c86c152a5abc0a367d49cbf265a18b738d8" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=57dc9c86c152a5abc0a367d49cbf265a18b738d8</a><br>; <br> commit 57dc9c86c152a5abc0a367d49cbf265a18b738d8<br> Author: Nuno Teixeira <eduardo@FreeBSD.org><br> AuthorDate: 2024-10-08 09:16:24 +0000<br> Commit: Nuno Teixeira <eduardo@FreeBSD.org><br> CommitDate: 2024-10-08 09:23:19 +0000<br> <br> devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to 1.16.0"<br> <br> OpenMP detection broken.<br> <br> See also:<br> <a href="https://github.com/Rdatatable/data.table/issues/6559" rel="noreferrer" target="_blank">https://github.com/Rdatatable/data.table/issues/6559</a><br>; <a href="https://github.com/Rdatatable/data.table/commit/096b20f1f1b9788787a826ba3d32177ed9836352" rel="noreferrer" target="_blank">https://github.com/Rdatatable/data.table/commit/096b20f1f1b9788787a826ba3d32177ed9836352</a><br>; <br> This reverts commit 5f823f135151a2a77b54ef0533c4c932e41ca771.<br> ---<br> devel/R-cran-data.table/Makefile | 4 +---<br> devel/R-cran-data.table/distinfo | 6 +++---<br> 2 files changed, 4 insertions(+), 6 deletions(-)<br> <br> diff --git a/devel/R-cran-data.table/Makefile b/devel/R-cran-data.table/Makefile<br> index 34a8aa0ea207..100dbe683927 100644<br> --- a/devel/R-cran-data.table/Makefile<br> +++ b/devel/R-cran-data.table/Makefile<br> @@ -1,5 +1,5 @@<br> PORTNAME= data.table<br> -DISTVERSION= 1.16.0<br> +DISTVERSION= 1.15.4<br> CATEGORIES= devel<br> DISTNAME= ${PORTNAME}_${DISTVERSION}<br> <br> @@ -12,8 +12,6 @@ LICENSE_FILE= ${WRKSRC}/LICENSE<br> <br> USES= cran:auto-plist,compiles pkgconfig<br> <br> -TESTING_UNSAFE= <a href="https://github.com/Rdatatable/data.table/issues/6559" rel="noreferrer" target="_blank">https://github.com/Rdatatable/data.table/issues/6559</a><br>; -<br> NO_ARCH_IGNORE= data_table.so<br> <br> OPTIONS_DEFINE= OPENMP<br> diff --git a/devel/R-cran-data.table/distinfo b/devel/R-cran-data.table/distinfo<br> index dfc347728df6..497612d9aa61 100644<br> --- a/devel/R-cran-data.table/distinfo<br> +++ b/devel/R-cran-data.table/distinfo<br> @@ -1,3 +1,3 @@<br> -TIMESTAMP = 1728300398<br> -SHA256 (data.table_1.16.0.tar.gz) = 58f8aec50099de80d84faa50295c17295d465f669be79b46c3c7ca18c56ef9cd<br> -SIZE (data.table_1.16.0.tar.gz) = 5302544<br> +TIMESTAMP = 1711960872<br> +SHA256 (data.table_1.15.4.tar.gz) = ab8065ff946d59ecaaf5eaf91a975495c07c30caad97a71205c72e41a740cb53<br> +SIZE (data.table_1.15.4.tar.gz) = 5387593<br> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><font color="#888888">Nuno Teixeira</font></div><div><div><font color="#888888"> FreeBSD UNIX: <eduardo@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br></font></div></div></div></div>;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJhvr0DqgSAp52NpddT7WMDFP9zSD4LmXjyLKyrUEioMg>