Date: Tue, 25 Dec 2007 17:45:52 +1100 From: Peter Jeremy <peterjeremy@optushome.com.au> To: Edwin Groothuis <edwin@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/bin/cp cp.c Message-ID: <20071225064552.GE53085@server.vk2pj.dyndns.org> In-Reply-To: <200712250040.lBP0eWn5060702@repoman.freebsd.org> References: <200712250040.lBP0eWn5060702@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Tue, Dec 25, 2007 at 12:40:32AM +0000, Edwin Groothuis wrote:
> When copying multiple files to a directory, make sure that a proper
> warning is given when the directory doesn't exist.
warnx("Target is not a directory");
exit(1);
would be more simply expressed as
errx(1, "Target is not a directory");
Maybe you should report the target name:
errx(1, "%s is not a directory", to.p_path);
> Submitted by: Edwin Groothuis <edwin@mavetju.org>
Normally, you don't bother listing yourself as the author.
--
Peter Jeremy
Please excuse any delays as the result of my ISP's inability to implement
an MTA that is either RFC2821-compliant or matches their claimed behaviour.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)
iD8DBQFHcKcg/opHv/APuIcRAt4zAKDEDYGLsu5kl69QjlR7Jbs7iaBxDwCfebyU
jJBoDLmtVbU56iMAyEqUh28=
=anQ9
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071225064552.GE53085>