Date: Tue, 10 Mar 2026 10:51:11 +0300 From: Gleb Popov <arrowd@freebsd.org> To: Yuri <yuri@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, dev-commits-ports-main@freebsd.org Subject: Re: git: 60817c50b4c8 - main - Mk/Uses: Add certs.mk to handle dependency on security/ca_root_nss Message-ID: <CALH631k-S3=qCzSfXufiVZg8rG1ZC2s5V0%2BP60Gk0gV%2BWZPdhA@mail.gmail.com> In-Reply-To: <8677eed4-c8a3-4aee-8305-f440a46d1b90@FreeBSD.org> References: <69aef1a8.4147d.6669a453@gitrepo.freebsd.org> <5xdq2qbbcr2h75y4zziudbo7cwx4pm6d7s3q3imk77z3t6iodj@vhv2jrsqfmag> <8677eed4-c8a3-4aee-8305-f440a46d1b90@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Tue, Mar 10, 2026 at 10:41 AM Yuri <yuri@freebsd.org> wrote:
>
> It doesn't matter that this is just a string substitution.
It does. A Uses module must have an added value.
> USES=certs:{arg} is a lot more elegant and more readable expression of
> that dependency.
No, in both cases one has to add a single line of text. USES=certs is
even more obscure,
because ca_root_nss is not the only way to get certs.
> This is why macros exist in many programming languages.
Again, a macro must add something to the table. For example, a
conditional evaluation based
on the FreeBSD version or something like that.
And I again want to point out that before rolling such changes one
should create a review, hear out opinions of other developers and
ideally get an approval from portmgr.
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631k-S3=qCzSfXufiVZg8rG1ZC2s5V0%2BP60Gk0gV%2BWZPdhA>